Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(compiler-cli): only generate template context declaration when used #39321

Closed
wants to merge 2 commits into from
Closed

perf(compiler-cli): only generate template context declaration when used #39321

wants to merge 2 commits into from

Conversation

@JoostK
Copy link
Member

@JoostK JoostK commented Oct 17, 2020

See individual commits
JoostK added 2 commits Oct 17, 2020
@JoostK
perf(compiler-cli): only generate template context declaration when used
5765203 
The variable declaration for a template context is only needed when it
is referenced from somewhere, so the TCB operation to generate the
declaration is marked as optional.
@JoostK
test(compiler-cli): remove spurious `console.error` call from a test
b4a2e3f 
Reporting the source file text to the console was left as a debugging
artifact.
@ngbot ngbot bot added this to the needsTriage milestone Oct 17, 2020
@google-cla google-cla bot added the cla: yes label Oct 17, 2020
@JoostK JoostK marked this pull request as ready for review Oct 17, 2020
@JoostK JoostK requested a review from alxhub Oct 17, 2020
alxhub
alxhub approved these changes Oct 30, 2020
View changes
josephperrott added a commit that referenced this issue Nov 2, 2020
@JoostK @josephperrott
perf(compiler-cli): only generate template context declaration when u…
1ac0500 
…sed (#39321)

The variable declaration for a template context is only needed when it
is referenced from somewhere, so the TCB operation to generate the
declaration is marked as optional.

PR Close #39321
josephperrott added a commit that referenced this issue Nov 2, 2020
@JoostK @josephperrott
test(compiler-cli): remove spurious console.error call from a test (#…
8356522 
…39321)

Reporting the source file text to the console was left as a debugging
artifact.

PR Close #39321
josephperrott added a commit that referenced this issue Nov 2, 2020
@JoostK @josephperrott
test(compiler-cli): remove spurious console.error call from a test (#…
40bf1e0 
…39321)

Reporting the source file text to the console was left as a debugging
artifact.

PR Close #39321
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Dec 3, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alxhub alxhub

Assignees
No one assigned
Labels
action: merge action: presubmit cla: yes comp: compiler refactoring target: rc
Projects
None yet
Milestone
needsTriage
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@JoostK @alxhub