New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(compiler): remove support for TypeScript 3.9 #39313
Conversation
Removes the TypeScript 3.9 checks since the framework is in the process of removing support (see angular/angular#39313). Also updates the Firebase functions to TS 4.0.
This commit removes TypeScript 3.9 support. BREAKING CHANGE: TypeScript 3.9 is no longer supported, please upgrade to TypeScript 4.0.
4dc57f9
to
4ffcd90
Compare
This commit removes TypeScript 3.9 support. BREAKING CHANGE: TypeScript 3.9 is no longer supported, please upgrade to TypeScript 4.0. PR Close #39313
Removes the TypeScript 3.9 checks since the framework is in the process of removing support (see angular/angular#39313). Also updates the Firebase functions to TS 4.0.
|
I had encountered an issue with TS 4 and 10.1 which was reported here, which is still happening with 11.0.0-rc.0 and TS 4. ERROR in src/app/some/some.component.ts:26:81 - error TS2729: Property 'some_id' is used before its initialization.
26 public data: any = {some_id: this?.some_id, date: new Date()};
~~~~~~~~~~~~~~~
src/app/some/some.component.ts:22:12
22 @Input() some_id
~~~~~~~~~~~~~~~
'some_id' is declared here.As it is evident, the variable is defined before its being used. |
|
@KapilSachdev, could you please create a new ticket and provide the necessary information (by following the template), so that the team can have a look? As a part of the new ticket, please also provide an example of the code that doesn't work, so that we can reproduce the problem. Thank you. |
|
Before creating a new issue i wanted to confirm one more thing, in case the behaviour is expected. @Input() some_id
public data: any = {some_id: this?.some_id, date: new Date()};
ngOnInit() {
}Moving the @Input() some_id
ngOnInit() {
public data: any = {some_id: this?.some_id, date: new Date()};
}Is this expected behaviour because |
|
@KapilSachdev I don't think your use-case is specific to Angular (the error is being produced by the TypeScript). You can see how different version of TypeScript handle this in TypeScript Playground. |
Removes the TypeScript 3.9 checks since the framework is in the process of removing support (see angular/angular#39313). Also updates the Firebase functions to TS 4.0.
Removes the TypeScript 3.9 checks since the framework is in the process of removing support (see angular/angular#39313). Also updates the Firebase functions to TS 4.0.
Removes the TypeScript 3.9 checks since the framework is in the process of removing support (see angular/angular#39313). Also updates the Firebase functions to TS 4.0.
Removes the TypeScript 3.9 checks since the framework is in the process of removing support (see angular/angular#39313). Also updates the Firebase functions to TS 4.0. (cherry picked from commit ab8ec83)
Removes the TypeScript 3.9 checks since the framework is in the process of removing support (see angular/angular#39313). Also updates the Firebase functions to TS 4.0.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This commit removes TypeScript 3.9 support.
NOTE: corresponding TS 3.9 integration tests will be removed later in a followup cleanup PR.
BREAKING CHANGE:
TypeScript 3.9 is no longer supported, please upgrade to TypeScript 4.0.
Does this PR introduce a breaking change?