go-sql-driver / mysql

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compile error of connCheck.go #1048

Merged

shogo82148 merged 2 commits into go-sql-driver:master from shogo82148:fix-compile-error-on-plan9

Jan 5, 2020

Contributor

shogo82148 commented Jan 5, 2020 •

edited

Description

fix compile error of connCheck.go on plan9

ref. #1047 (comment)

$ GOOS=plan9 GOARCH= amd64 go build github.com/go-sql-driver/mysql
# github.com/go-sql-driver/mysql
./conncheck.go:42:15: undefined: syscall.EAGAIN
./conncheck.go:42:40: undefined: syscall.EWOULDBLOCK

Checklist

Code compiles correctly
Created tests which fail without the change (if possible)
All tests passing
Extended the README / documentation, if necessary
Added myself / the copyright holder to the AUTHORS file


          fix compile error of connCheck.go

ceed4d4

shogo82148 reviewed

  
      @@ -6,7 +6,8 @@
    
        // License, v. 2.0. If a copy of the MPL was not distributed with this file,

        // You can obtain one at http://mozilla.org/MPL/2.0/.

        // +build !windows,!appengine

        // +build linux darwin

shogo82148 Jan 5, 2020
Author Contributor

connCheck may work unix-like OSs (e.g. aix, dragonfly, freebsd, netbsd, openbsd, solaris), but I'm not sure.
can anyone check it?

julienschmidt Jan 5, 2020
Member

At least it cross-compiles. I would add them there as well

Member

methane commented Jan 5, 2020

I think we can drop the deprecated "appengine" build tag because we dropped Go 1.9 already.


          remove "appengine" build tag

225bd12

Contributor Author

shogo82148 commented Jan 5, 2020

I see
I removed the "appengine" build tag.

methane approved these changes

shogo82148 merged commit 8723940 into go-sql-driver:master

3 checks passed

3 checks passed

WIP Ready for review

Details

continuous-integration/travis-ci/pr The Travis CI build passed

Details

coverage/coveralls Coverage decreased (-0.008%) to 80.566%

Details

shogo82148 deleted the shogo82148:fix-compile-error-on-plan9 branch

Contributor Author

shogo82148 commented Jan 5, 2020

merged. thanks!

sthagen added a commit to sthagen/mysql that referenced this pull request


          Merge pull request #6 from go-sql-driver/master

92acdad

fix compile error of connCheck.go (go-sql-driver#1048)

julienschmidt added this to the v1.5.0 milestone

julienschmidt mentioned this pull request

conncheck: build on more supported platforms #1051

Merged

5 of 5 tasks complete

tz70s added a commit to tz70s/mysql that referenced this pull request


          fix compile error of connCheck.go (go-sql-driver#1048)

13572bb

* fix compile error of connCheck.go

* remove "appengine" build tag

tz70s added a commit to tz70s/mysql that referenced this pull request


          fix compile error of connCheck.go (go-sql-driver#1048)

43b3352

* fix compile error of connCheck.go

* remove "appengine" build tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.