Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix encoding errors #227
Fix encoding errors #227
Conversation
i got a few encoding errors using the library, this fixes them
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
@googlebot I signed it |
|
CLAs look good, thanks! |
every output is now json
|
Your CL has 45 files changed. And a bunch of code commented out. Could you clean it up or open a new PR with a clean version, perhaps? |
|
If you have simple example where Fire failed that would be useful too. |
Hi, i was using this library, and it had difficulty dealing with some utf-8 outputs, so i added the necessary changes to make it work.