Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encoding errors #227

Open
wants to merge 4 commits into
base: master
from
Open

Fix encoding errors #227

wants to merge 4 commits into from

Conversation

@cauefcr
Copy link

@cauefcr cauefcr commented Feb 25, 2020

Hi, i was using this library, and it had difficulty dealing with some utf-8 outputs, so i added the necessary changes to make it work.

cauefcr added 2 commits Feb 25, 2020
i got a few encoding errors using the library, this fixes them
@googlebot
Copy link

@googlebot googlebot commented Feb 25, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no label Feb 25, 2020
@cauefcr
Copy link
Author

@cauefcr cauefcr commented Feb 25, 2020

@googlebot I signed it

@googlebot
Copy link

@googlebot googlebot commented Feb 25, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Feb 25, 2020
cauefcr added 2 commits Feb 25, 2020
every output is now json
@dbieber
Copy link
Member

@dbieber dbieber commented Feb 26, 2020

Your CL has 45 files changed. And a bunch of code commented out. Could you clean it up or open a new PR with a clean version, perhaps?
Then I could more easily see what changes were needed to get the encoding right.

@dbieber
Copy link
Member

@dbieber dbieber commented Feb 28, 2020

If you have simple example where Fire failed that would be useful too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.