test(zone.js): test zone.js packge with tgz by JiaLiPassion · Pull Request #38649 · angular/angular

JiaLiPassion · 2020-08-31T04:49:23Z

Zone.js 0.11.0 release an empty bundle, and now the npm_package tests all target
bazel rule npm_package, but not npm_package.pack, and these two rules may
generate different results, for example, Zone.js 0.11.0's issue is package.json
define files array which make the bundle only include the files in the files array.
So this PR install the zone.js package from the archive generated from npm_package.pack rule.

gkalpak

Nit: The commit message should be of type build or test. Otherwise lgtm.

While I don't mind the changes, I wonder whether we are testing the implementation of npm_package vs npm_package.pack. Is it expected that npm_package would yield different results than npm_package.pack? Or is it a bug in npm_package?

ngbot · 2020-09-15T23:55:09Z

I see that you just added the action: merge label, but the following checks are still failing:
status "pullapprove" is failing
2 pending code reviews

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

JiaLiPassion · 2020-09-16T12:17:12Z

@gkalpak, could you check this PR again? Thanks.

JiaLiPassion · 2020-09-16T21:05:26Z

@gkalpak , Sorry, it happened again, I pushed the wrong commit. Please take a look again, and I added the logic to remove zone.js-dist/archive dir before publish archive in circleci here https://github.com/angular/angular/pull/38649/files#diff-1d37e48f9ceff6d8030570cd36286a61R569

gkalpak

No worries, @JiaLiPassion. Thx for making the changes 👍

gkalpak

Generally lgtm, but I am a little concernd about the potential Windows incompatibility. (We need to investigate that before merging.)

BTW, there's a typo in the commit message header:

-test(zone.js): test zone.js packge with tgz
+test(zone.js): test zone.js package with tgz

gkalpak · 2020-09-19T17:31:26Z

This command fails for me on Windows. I don't know yet whether it is just me or an npm_package.pack issue with Windows, but I don't want to change this script in a way that breaks Windows users.
(NOTE: This script is also used when you want to test angular.io against the locally built Angular packages.)

I have started a discussion here (sorry, not public).

Yeah, I tested it too, it throw a error like this.

java.io.IOException: ERROR: src/main/native/windows/processes-jni.cc(356): NativeProcess:WriteStdin(1153200)

IgorMinar

this change looks good to me, if we can resolve the Windows incompatibility.

AndrewKushnir · 2020-10-15T21:19:03Z

FYI, replacing "merge" label with "cleanup" one since there is a conflict with master branch. Feel free to put the "merge" label back once this PR is rebased. Thank you.

JiaLiPassion · 2020-10-15T23:47:14Z

@AndrewKushnir , got it, thanks!

@gkalpak, I tried again, to run bazel clean and build on windows, it seems now it run successfully, could you check it again?
Thank you!

gkalpak · 2020-10-17T18:33:21Z

It is still failing for me 😕

Zone.js 0.11.0 release an empty bundle, and now the npm_package tests all target bazel rule `npm_package`, but not `npm_package.pack`, and these two rules may generate different results, for example, Zone.js 0.11.0's issue is `package.json` define files array which make the bundle only include the files in the files array. So this PR install the zone.js package from the archive generated from `npm_package.pack` rule.

angular-automatic-lock-bot · 2020-11-19T16:32:08Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Aug 31, 2020

JiaLiPassion marked this pull request as draft August 31, 2020 04:49

pullapprove Bot requested review from gkalpak and mhevery August 31, 2020 04:49

JiaLiPassion force-pushed the zone-npm-test branch 7 times, most recently from 5af75f5 to ecf7a0d Compare August 31, 2020 09:23

JiaLiPassion added the area: zones Issues related to zone.js label Aug 31, 2020

ngbot Bot added this to the needsTriage milestone Aug 31, 2020

JiaLiPassion added the target: minor This PR is targeted for the next minor release label Aug 31, 2020

JiaLiPassion marked this pull request as ready for review August 31, 2020 09:24

gkalpak suggested changes Aug 31, 2020

View reviewed changes

Comment thread scripts/build/zone-js-builder.js Outdated

Comment thread scripts/build/zone-js-builder.js Outdated

Comment thread scripts/build/zone-js-builder.js Outdated

Comment thread scripts/build/zone-js-builder.js Outdated

JiaLiPassion force-pushed the zone-npm-test branch from ecf7a0d to ac3300d Compare September 10, 2020 04:03

JiaLiPassion requested a review from gkalpak September 10, 2020 04:03

JiaLiPassion changed the title ~~feat(zone.js): test zone.js packge with tgz~~ test(zone.js): test zone.js packge with tgz Sep 14, 2020

JiaLiPassion force-pushed the zone-npm-test branch from ac3300d to 5f9e20b Compare September 14, 2020 21:52

mhevery approved these changes Sep 15, 2020

View reviewed changes

mhevery added the action: merge The PR is ready for merge by the caretaker label Sep 15, 2020

gkalpak suggested changes Sep 16, 2020

View reviewed changes

Comment thread scripts/build/zone-js-builder.js Outdated

Comment thread scripts/build/zone-js-builder.js Outdated

Comment thread scripts/build/zone-js-builder.js Outdated

Comment thread scripts/build/zone-js-builder.js Outdated

Comment thread scripts/build/zone-js-builder.js Outdated

JiaLiPassion force-pushed the zone-npm-test branch from 5f9e20b to 7a270d2 Compare September 16, 2020 21:02

JiaLiPassion requested a review from gkalpak September 16, 2020 21:09

JiaLiPassion force-pushed the zone-npm-test branch from 7a270d2 to 73d4969 Compare September 16, 2020 21:43

gkalpak suggested changes Sep 17, 2020

View reviewed changes

Comment thread scripts/build/zone-js-builder.js Outdated

Comment thread scripts/build/zone-js-builder.js Outdated

Comment thread .circleci/config.yml Outdated

JiaLiPassion requested a review from gkalpak September 18, 2020 01:06

gkalpak suggested changes Sep 19, 2020

View reviewed changes

JiaLiPassion force-pushed the zone-npm-test branch from d6c8b43 to b329a8d Compare September 19, 2020 23:48

JiaLiPassion mentioned this pull request Sep 20, 2020

release: cut the zone.js-0.11.2 release #38911

Closed

IgorMinar reviewed Oct 14, 2020

View reviewed changes

AndrewKushnir added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Oct 15, 2020

JiaLiPassion force-pushed the zone-npm-test branch from b329a8d to 8cb9159 Compare October 15, 2020 23:05

JiaLiPassion removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Oct 15, 2020

JiaLiPassion requested a review from gkalpak October 15, 2020 23:46

JiaLiPassion force-pushed the zone-npm-test branch from 8cb9159 to 4b05568 Compare October 19, 2020 00:30

fixup! test(zone.js): test zone.js package with tgz

73c5494

This comment has been minimized.

Sign in to view

google-cla Bot added cla: no and removed cla: yes labels Oct 19, 2020

This comment has been minimized.

Sign in to view

google-cla Bot added cla: yes and removed cla: no labels Oct 19, 2020

gkalpak approved these changes Oct 19, 2020

View reviewed changes

gkalpak added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Oct 19, 2020

JiaLiPassion added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Oct 19, 2020

AndrewKushnir closed this in d379396 Oct 19, 2020

gkalpak mentioned this pull request Oct 27, 2020

build: ensure script that build the Zone.js package can be run from any directory #39455

Closed

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Nov 19, 2020

Conversation

JiaLiPassion commented Aug 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gkalpak left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ngbot Bot commented Sep 15, 2020

Uh oh!

JiaLiPassion commented Sep 16, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JiaLiPassion commented Sep 16, 2020

Uh oh!

gkalpak left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gkalpak left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gkalpak Sep 19, 2020

Choose a reason for hiding this comment

Uh oh!

JiaLiPassion Sep 19, 2020

Choose a reason for hiding this comment

Uh oh!

IgorMinar left a comment

Choose a reason for hiding this comment

Uh oh!

AndrewKushnir commented Oct 15, 2020

Uh oh!

JiaLiPassion commented Oct 15, 2020

Uh oh!

gkalpak commented Oct 17, 2020

Uh oh!

This comment has been minimized.

This comment has been minimized.

angular-automatic-lock-bot Bot commented Nov 19, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

JiaLiPassion commented Aug 31, 2020 •

edited

Loading