JavaScript: Add modelling for Module.prototype._compile.#4499
Merged
Conversation
asgerf
reviewed
Oct 19, 2020
asgerf
left a comment
asgerf
left a comment
Contributor
There was a problem hiding this comment.
LGTM. The autoformat check is failing.
max-schaefer
force-pushed
the
js/module_compile
branch
from
c7e4f1a to
e1d90e9
Compare
Contributor
Author
|
Hopefully fixed now. |
asgerf
approved these changes
Oct 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Undocumented API, so one might question whether it is worth it. On the other hand, it would allow us to derive a sink summary for this unaccountably popular npm module (>2M weekly downloads).