Return undefined for finding file ranges on empty URI#620
Merged
aeisenberg merged 1 commit intoOct 19, 2020
Conversation
aeisenberg
force-pushed
the
aeisenberg/ast-viewer-no-location
branch
3 times, most recently
from
95c68c3 to
b119b46
Compare
adityasharad
previously approved these changes
Oct 16, 2020
adityasharad
left a comment
adityasharad
left a comment
Contributor
There was a problem hiding this comment.
Looks sensible. Thanks for the clear tests!
Contributor
Author
|
Please don't merge yet. The failing test is due to a legitimate bug in the source. Working on a fix now. |
Also, refactor resolveSourceFile to make it easier to read. And add unit tests for resolveSourceFile. This commit fixes a bug in resolveSourceFile where the `pathWithinSourceArchive` was being removed and appended to the `sourceArchiveZipPath`. In normal situations, we don't hit this bug because most database source archive uris have an empty path for the `pathWithinSourceArchive`.
aeisenberg
force-pushed
the
aeisenberg/ast-viewer-no-location
branch
from
b119b46 to
61c2f9c
Compare
Contributor
Author
|
@adityasharad could you take another look since this PR now fixes a second bug. |
jcreedcmu
approved these changes
Oct 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, refactor resolveSourceFile to make it easier to read.
And add unit tests for resolveSourceFile.
This fixes a bug where clicking on an item in the AST viewer when the location is invalid threw an exception.
This PR also fixes a bug in resolveSourceFile where the
pathWithinSourceArchivewas being removed and appended to thesourceArchiveZipPath. In normal situations, we don't hit this bug because most database source archive uris have an empty path for thepathWithinSourceArchive.Checklist
@github/docs-content-dsphas been cc'd in all issues for UI or other user-facing changes made by this pull request.