Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for flowjs #863

Open
Rafi993 opened this issue Aug 26, 2018 · 3 comments
Open

Support for flowjs #863

Rafi993 opened this issue Aug 26, 2018 · 3 comments

Comments

@Rafi993
Copy link

@Rafi993 Rafi993 commented Aug 26, 2018

I have been trying to setup flowjs integration in code climate. I did search through the docs I couldn't find explicit information ( except for eslint flow plugin which does not run flow ). So is flowjs supported now if so how would I proceed with it now. If not will it be added in the future.

@wfleming
Copy link
Member

@wfleming wfleming commented Aug 27, 2018

@Rafi993 are there particular tools for linting Flow.js that you would like to see supported? I'm not familiar with Flow.js, but it seems like it's a pretty standard JS library, so normal JS code written using Flow should be analyzable by Code Climate's usual JavaScript analysis.

@Rafi993
Copy link
Author

@Rafi993 Rafi993 commented Aug 28, 2018

Yes support for flowjs is a selling point for me. Flow comes with cli tool for linting. There are also some eslint plugins to run flow ( adding that support will also do ) https://github.com/amilajack/eslint-plugin-flowtype-errors

@wfleming
Copy link
Member

@wfleming wfleming commented Aug 28, 2018

We'd be happy to consider PRs to add plugins to our ESLint plugin.

Building new Code Climate engines wrapping Flow's linter is not a priority for us right now, sorry. I've added the "help wanted" tag to this issue: if you or somebody else wanted to write & maintain an engine wrapping that tool, we would be able to support that engine on our platform. There's a spec covering how engines work and are packaged, and some of our smaller engines make for good examples to look at for basic engine structure & packaging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.