Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport new installations of MySQL Connector C 6.1 #448
Conversation
change connector path to support amd64 installation of mysql connector c
swap client to mysql instead of mariadb
Codecov Report
@@ Coverage Diff @@
## master #448 +/- ##
=======================================
Coverage 86.60% 86.60%
=======================================
Files 12 12
Lines 1530 1530
=======================================
Hits 1325 1325
Misses 205 205 Continue to review full report at Codecov.
|
| client = "mysqlclient" | ||
| # client = "mariadbclient" |
methane
Oct 15, 2020
Member
Don't do that. MySQL Connector/C 6.1 is too old, and new libmysqlclient doesn't support static linking.
Don't do that. MySQL Connector/C 6.1 is too old, and new libmysqlclient doesn't support static linking.
mddicicco
Oct 15, 2020
Author
The whole reason I landed on 6.1 was because that is what the build was looking for. I aimed for making the minimum changes possible for it to work. Prior to these changes the build fails because it is searching for a 'mariadb' directory inside the 'MySQL Connector C 6.1' directory (that is caused by line 16), and the 'MySQL Connector C 6.1' directory if installed today lands in the x64 'Program Files' directory
The whole reason I landed on 6.1 was because that is what the build was looking for. I aimed for making the minimum changes possible for it to work. Prior to these changes the build fails because it is searching for a 'mariadb' directory inside the 'MySQL Connector C 6.1' directory (that is caused by line 16), and the 'MySQL Connector C 6.1' directory if installed today lands in the x64 'Program Files' directory
methane
Oct 16, 2020
•
Member
MySQL Connector/C 6.1 is old product. It is not recommended/default option. So don't try make it success without modification. MariaDB Connector/C must be default option for Windows.
MySQL Connector/C 6.1 is old product. It is not recommended/default option. So don't try make it success without modification. MariaDB Connector/C must be default option for Windows.
New installations of MySQL Connector C 6.1 default to 'C:\Program Files.." not 'C:\Program Files (x86)..'.
This update also corrects the setup_windows.py client from 'mariadbclient' to 'mysqlclient'