Codecov Report

Merging #185 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #185   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          20     20           
  Lines        1662   1662           
  Branches       89     89           
=====================================
  Hits         1662   1662

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bb3786...2e05fef. Read the comment docs.

The asynctest library is not compatible in Python 3.8. It was recently added in #159 by @lysnikolaou
Is there any workaround for it? Can we make do without asynctest?

@Mariatta the asynctest library provides mocks for async functions. We could use the newly added AsyncMock in unittest, but we would need to update to 3.8 immediately for that.

ok thanks for the info. Hmm there is not yet 3.8 Python environment in Heroku, so we can't do it 😟

Seems like Python 3.8.0 is now available in Heroku. Think we can upgrade?

I'm not sure, what would be best to do. In case @brettcannon says we should upgrade, I could go ahead and push a PR to remove the asynctest dependency and update all the relevant tests.

I always say you should dogfood what you produce, and since this is for Python then we should use Python 3.8 if it's available.

It seems like there is a problem with aiohttp as well. After I removed the asynctest dependency, I get DeprecationWarnings due to aiohttp calling asyncio.shield() with the loop argument which is deprecated as of 3.8.

Running pytest -p no:warnings is ok, which shows that asynctest can be removed without a problem.

Opened #211 for this, which fails on Travis with 3.7, but does not with 3.8-dev.