refactor: navigation-helper.ts#8834
Merged
NathanWalker merged 12 commits intoNativeScript:masterfrom Sep 10, 2020
Merged
Conversation
merged master
Contributor
|
Nice @tarunama thank you 👍 |
NathanWalker
approved these changes
Sep 9, 2020
rigor789
approved these changes
Sep 10, 2020
NathanaelA
reviewed
Sep 10, 2020
Contributor
NathanaelA
left a comment
NathanaelA
left a comment
There was a problem hiding this comment.
Am I Correct in my reading of the Code that their is no Changes other than to just Cleanup the Code a bit and make it easier to read.
Contributor
|
@NathanaelA correct. |
NathanWalker
pushed a commit
that referenced
this pull request
Sep 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
No changes.
What is the new behavior?
No changes.