chore(): use Isomer dependency instead of internal animation #21828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ionitron-bot
bot
added
package: angular
Contributor
Author
|
Isomer version will be bumped to 1.0.0 prior to merging |
liamdebeasi
commented
Jul 27, 2020
angular/src/index.ts
Outdated
| export { AnimationBuilder, Gesture, GestureConfig, GestureDetail, mdTransitionAnimation, iosTransitionAnimation, NavComponentWithProps } from '@ionic/core'; | ||
|
|
||
| // ISOMER | ||
| export * from '@isomer/angular'; |
Contributor
Author
There was a problem hiding this comment.
This works, but is it a good idea to do?
Contributor
There was a problem hiding this comment.
Probably use named exports instead so we don't accidentally add something to the public api
liamdebeasi
requested review from
adamdbradley,
brandyscarney and
mhartington
and removed request for
mhartington
brandyscarney
approved these changes
Jul 28, 2020
adamdbradley
approved these changes
Jul 30, 2020
Contributor
Author
|
Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this introduce a breaking change?
Other information