Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCollapsed Editor can be resized and dragging down doesn't increase code view #1110
Comments
|
I played around a bit to see what is causing it and found that the Here is a snippet from JSON Lens Renderer: hoppscotch/components/lenses/renderers/JSONLensRenderer.vue Lines 43 to 57 in 3cd2a2a |
|
Another possible option is to restart the efforts for moving to CodeMirror. I had attempted before, just that the only issue was that editor expanded the response panel. Ace is really difficult to work with and pretty much impossible to test the functionality of due to its weird Webpack Resolution thingy and the codebase feels really legacy. CodeMirror is pretty modern, supports mobile devices and we already have a sorta working implementation going. You can check out the stale branch in my fork. https://github.com/AndrewBastin/hoppscotch/tree/feat/move-to-codemirror |
|
Let me check. |
What about monaco ? It's the VSCode editor https://github.com/egoist/vue-monaco I can take this issue if no on is working on it |
|
@AndrewBastin once implemented a codemirror port. We refused monaco because it doesn't had mobile responsive support. We can consider it if it is responsive. Andrew, wdyt? It looks like now there's a monaco editor component for Vue. |
Indeed, from their Readme :
|
To be honest, I prefer Monaco as well as it is a lot more battle tested and advanced compared to CodeMirror, but Monaco doesn't support mobile devices as stated by @LeoMartinDev and we don't exactly have a definite plan to drop mobile devices just yet. But if that happens and we decide to drop mobile support for Hoppscotch, we can choose to move ahead with Monaco. |
Describe the bug
When I pull the resize button of the code editor, it doesn't the resize the code in the editor.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
I expected the code to resize as I drag down the button.
Screenshots

If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Additional context
When I press the expand button, it works though.