Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for elements Water.css supports that some browsers don't #233

Open
kylejrp opened this issue Oct 13, 2020 · 3 comments · May be fixed by #234
Open

Add documentation for elements Water.css supports that some browsers don't #233

kylejrp opened this issue Oct 13, 2020 · 3 comments · May be fixed by #234

Comments

@kylejrp
Copy link
Collaborator

@kylejrp kylejrp commented Oct 13, 2020

See #231 for context

We should include in either the example page or our readme that we style some elements like <dialog> that are not supported by other browsers. You can check caniuse for browser support for HTML elements.

We would take a pull request that would add this to the documentation. Ideally, you would check all the HTML elements in the example page and see what elements we style that are unsupported by major browsers. I suspect that it's just <dialog>, but it would be nice to confirm.

@PawanKolhe
Copy link

@PawanKolhe PawanKolhe commented Oct 14, 2020

I can work on this. Please assign it to me.

@Pedroemanuelavelar
Copy link

@Pedroemanuelavelar Pedroemanuelavelar commented Oct 17, 2020

Hello done check out the pull request! Please return feedback

@KaustubhDamania KaustubhDamania linked a pull request that will close this issue Oct 17, 2020
@Pedroemanuelavelar
Copy link

@Pedroemanuelavelar Pedroemanuelavelar commented Oct 17, 2020

Add this issue for me i already finished it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.