Skip to content

/ freeCodeCamp

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable github integration #38678

Merged
merged 2 commits into from Apr 30, 2020
Merged

feat: enable github integration #38678

merged 2 commits into from Apr 30, 2020

Conversation

@raisedadead
Copy link
Member

raisedadead commented Apr 29, 2020

No description provided.

@gitpod-io
Copy link

gitpod-io bot commented Apr 29, 2020 •
edited

@raisedadead raisedadead mentioned this pull request Apr 29, 2020
Closed
@ojeytonwilliams
ojeytonwilliams requested changes Apr 29, 2020
View changes
.github/workflows/cypress.yml Outdated Show resolved Hide resolved
raisedadead and others added 2 commits Apr 22, 2020
@raisedadead
feat: enable github integration
e391303
@raisedadead @ojeytonwilliams
Update .github/workflows/cypress.yml
Loading status checks…
90a82d2 
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
@raisedadead raisedadead force-pushed the cypress-integrate-cypress-io branch from f1264ab to 90a82d2 Apr 29, 2020
@raisedadead raisedadead marked this pull request as ready for review Apr 29, 2020
@raisedadead raisedadead requested a review from freeCodeCamp/dev-team as a code owner Apr 29, 2020
@raisedadead raisedadead requested a review from ojeytonwilliams Apr 29, 2020
@ojeytonwilliams
ojeytonwilliams approved these changes Apr 30, 2020
View changes
Copy link
Contributor

ojeytonwilliams left a comment

Looks good! One thing I'm not 100% on is which branches will be watched? If it triggers on every push and every PR I imagine we'll use up the quota. That is unless fCC qualifies as a non-commercial entity.

Regardless, we might as well try this and see.
@raisedadead
Copy link
Member Author

raisedadead commented Apr 30, 2020

Great news!

Our OSS Application just came through:

image
@raisedadead
Copy link
Member Author

raisedadead commented Apr 30, 2020

I checked everything we have unlimited runs, and even then I am restricting this to pushes to master, production-** and all pull requests.
@raisedadead raisedadead merged commit 1dabaf8 into master Apr 30, 2020
7 checks passed
7 checks passed
Cypress run
Details
Cypress run
Details
Gitpod Open an online workspace in Gitpod
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
cypress: default-group 4 tests passed in 00:07
Details
cypress: default-group (merge) 4 tests passed in 00:08
Details
@raisedadead raisedadead deleted the cypress-integrate-cypress-io branch Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ojeytonwilliams ojeytonwilliams

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@raisedadead @ojeytonwilliams
You can’t perform that action at this time.