Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the 'Coercing non-XML name' warning. #418

Merged
merged 1 commit into from Apr 26, 2019
Merged

Conversation

@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Apr 26, 2019

This can be helpful in finding the code triggering the warning.

This can be helpful in finding the code triggering the warning.
@codecov-io
Copy link

@codecov-io codecov-io commented Apr 26, 2019

Codecov Report

Merging #418 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #418   +/-   ##
=======================================
  Coverage   90.79%   90.79%           
=======================================
  Files          50       50           
  Lines        6952     6952           
  Branches     1328     1328           
=======================================
  Hits         6312     6312           
  Misses        481      481           
  Partials      159      159
Impacted Files Coverage Δ
html5lib/_ihatexml.py 45.27% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d8919a...e7f7570. Read the comment docs.

1 similar comment
@codecov-io
Copy link

@codecov-io codecov-io commented Apr 26, 2019

Codecov Report

Merging #418 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #418   +/-   ##
=======================================
  Coverage   90.79%   90.79%           
=======================================
  Files          50       50           
  Lines        6952     6952           
  Branches     1328     1328           
=======================================
  Hits         6312     6312           
  Misses        481      481           
  Partials      159      159
Impacted Files Coverage Δ
html5lib/_ihatexml.py 45.27% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d8919a...e7f7570. Read the comment docs.

@gsnedders gsnedders merged commit 4b22754 into html5lib:master Apr 26, 2019
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 90.79%)
Details
codecov/project 90.79% (+0%) compared to 2d8919a
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Ms2ger Ms2ger deleted the Ms2ger:xml-name branch Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.