Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMoving to a command dispatch for PRs #586
Merged
Conversation
Fixes: #584 This will mean that when a PR is opened, linting and an initial build of the binaries will be performed to ensure there are no obvious error. The PR will have a comment added to it suggesting that the user needs a maintainer to run the acceptance tests. The maintainer will run the command /run-acceptance-tests and will wait for the results This will trigger a full end-to-end set of tests including spinning up the test infrastructure. It is super important that the PR is checked that no secrets etc are leaked before running the test command Please note, as this is a command dispatch, this cannot be tested from a PR - it must be in master and we can interate there!
|
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes: #584
This will mean that when a PR is opened, linting and an initial
build of the binaries will be performed to ensure there are no
obvious error.
The PR will have a comment added to it suggesting that the user needs
a maintainer to run the acceptance tests. The maintainer will run
the command /run-acceptance-tests and will wait for the results
This will trigger a full end-to-end set of tests including spinning
up the test infrastructure.
It is super important that the PR is checked that no secrets etc are
leaked before running the test command
Please note, as this is a command dispatch, this cannot be tested from
a PR - it must be in master and we can interate there!