Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMigrate some material tests to nnbd #67477
Merged
+185
−256
Conversation
|
|
| @@ -96,8 +96,7 @@ abstract class PopupMenuEntry<T> extends StatefulWidget { | |||
| /// * [showMenu], a method to dynamically show a popup menu at a given location. | |||
| /// * [PopupMenuButton], an [IconButton] that automatically shows a menu when | |||
| /// it is tapped. | |||
| // ignore: prefer_void_to_null, https://github.com/dart-lang/sdk/issues/34416 | |||
| class PopupMenuDivider extends PopupMenuEntry<Null> { | |||
| class PopupMenuDivider extends PopupMenuEntry<Never> { | |||
gspencergoog
Oct 7, 2020
Contributor
Aww, I'm jealous: I haven't found a reason to use Never yet!
Aww, I'm jealous: I haven't found a reason to use Never yet!
goderbauer
merged commit 3961a12
into
flutter:master
32 checks passed
32 checks passed
cla/google
All necessary CLAs are signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
dart-lang/sdk#40146
#62886