faif / python-patterns

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added singleton pattern. #303

Closed

hoseinfzad wants to merge 2 commits into faif:master from hoseinfzad:master

hoseinfzad commented Oct 6, 2019

The Singleton design pattern creates only one object of the class

hoseinfzad added 2 commits


          added singleton pattern.

2d6858e


          add singleton pattern to creational patterns

daa7c6a

Contributor

gyermolenko commented Oct 7, 2019

please review #279

adihat reviewed

patterns/behavioral/singleton.py Outdated

  
            def __setattr__(self, name):

                return setattr(self.instance, name)

Comment on lines 21 to 22

adihat Oct 7, 2019

Changes:

def __setattr__(self, name, value):
    return setattr(self.instance, name, value)

Reason: The signature of SingletonObject.__setattr__ doesn't match the signature of base method in class object

adihat commented Oct 7, 2019

@hoseinfzad Please see #256
As @faif mentioned, there is no plan to add singleton pattern to this repo as its considered an anti pattern. There is a plan to maintain a list of these anti patterns in the readme file instead of having to go through all the issues.

faif closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.