Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDoctests all around #283
Doctests all around #283
Conversation
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
==========================================
+ Coverage 72.84% 72.99% +0.14%
==========================================
Files 62 62
Lines 2224 2177 -47
==========================================
- Hits 1620 1589 -31
+ Misses 604 588 -16
Continue to review full report at Codecov.
|
This PR is for discussion purposes but it contains changes which are ready to merge.
Please review from easiest to longest: Template, Adapter, Memento
Template: not much changed (I expect it to be the common case for other examples)
Adapter: I don't know why the diff is like that, it shows many functions I didn't touch. My advice for this particular commit is to compare before/after files by eye.
Because the important change is in one line:
before
after
"..." dots represent module and object memory address.
Memento
most of traceback is intentionally hidden under "..."
I will also describe some transition subtleties in #258 to discuss further
@faif please let me know if I should proceed with other examples.
Although this PR is ready as is.