Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to render stories in React.StrictMode #12734

Open
oliviertassinari opened this issue Oct 11, 2020 · 1 comment
Open

Add option to render stories in React.StrictMode #12734

oliviertassinari opened this issue Oct 11, 2020 · 1 comment

Comments

@oliviertassinari
Copy link
Contributor

@oliviertassinari oliviertassinari commented Oct 11, 2020

Is your feature request related to a problem? Please describe

I would like to render all my stories in strict mode, to anticipate this mode becoming the default in React.

Describe the solution you'd like

I have noticed the global env XSTORYBOOK_EXAMPLE_APP but it seems to be private. It's not documented.

Describe alternatives you've considered

Next.js offers interesting options: https://nextjs.org/docs/api-reference/next.config.js/react-strict-mode.

We strongly suggest you enable Strict Mode in your Next.js application to better prepare your application for the future of React.

Additional context

StrictMode is enabled by default in Create React App. I'm opening the issue because we go a bug reported linked to our workflow where we don't have StrictMode enabled.

@shilman
Copy link
Member

@shilman shilman commented Oct 11, 2020

@oliviertassinari this should be an easy one and worthwhile. PRs welcome and if nothing comes in I'll try to make sure it happens for 6.1.

@shilman shilman added this to Ecosystem in 6.1 scratch Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
6.1 scratch
Ecosystem
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.