Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added rail fence cipher #3188

Merged
merged 3 commits into from Oct 12, 2020
Merged

Added rail fence cipher #3188

merged 3 commits into from Oct 12, 2020

Conversation

@PotatoK123
Copy link
Contributor

@PotatoK123 PotatoK123 commented Oct 11, 2020 •
edited

Describe your change:

Added rail fence cipher

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
PotatoK123 added 3 commits Oct 11, 2020
@PotatoK123
Added rail fence cipher
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
c8f87d4
@PotatoK123
Update rail_fence_cipher.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7e52440
@PotatoK123
Update rail_fence_cipher.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
efe6200
@PotatoK123 PotatoK123 requested a review from cclauss as a code owner Oct 11, 2020
@cclauss
Copy link
Member

@cclauss cclauss commented Oct 11, 2020

#2510 (comment)
@M055277702
M055277702 approved these changes Oct 11, 2020
View changes
@AnupKumarPanwar
AnupKumarPanwar approved these changes Oct 12, 2020
View changes
@AnupKumarPanwar AnupKumarPanwar merged commit 3859c65 into TheAlgorithms:master Oct 12, 2020
3 checks passed
3 checks passed
codespell
Details
pre-commit
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnupKumarPanwar AnupKumarPanwar

@M055277702 M055277702

@cclauss cclauss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@PotatoK123 @cclauss @AnupKumarPanwar @M055277702
You can’t perform that action at this time.