Skip to content

/ biojava

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AtomCache doesn't fetch obsolete entries with mmtf #754

Open
sbliven opened this issue Mar 15, 2018 · 0 comments
Open

AtomCache doesn't fetch obsolete entries with mmtf #754

sbliven opened this issue Mar 15, 2018 · 0 comments
Labels
bug
Milestone
BioJava 5.3.1

Comments

@sbliven
Copy link
Member

@sbliven sbliven commented Mar 15, 2018

AtomCache doesn't fetch obsolete entries if configured to use MMTF.

I believe that RCSB is not providing obsolete MMTF files. In this case we should fall back to mmcif. We should also throw exceptions for methods like MMTFReader.setObsolete(FETCH_OBSOLETE).
sbliven added a commit to sbliven/biojava-sbliven that referenced this issue Mar 15, 2018
@sbliven
Add mmtf to TestAtomCache
Loading status checks…
c307924 
One test does not pass, illustrating biojava#754
@sbliven sbliven modified the milestones: BioJava 5.1.0, BioJava 5.0.1 Mar 15, 2018
@sbliven sbliven added the bug label Mar 15, 2018
sbliven added a commit to sbliven/biojava-sbliven that referenced this issue Mar 22, 2018
@sbliven
Work around biojava#754 in EcodParseTest
Loading status checks…
2eb11cf 
Falls back to mmcif for obsolete files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
BioJava 5.3.1
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@sbliven
You can’t perform that action at this time.