Skip to content

/ biojava

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advance notice: next release 5.3.0 #848

Closed
josemduarte opened this issue Sep 2, 2019 · 6 comments
Closed

Advance notice: next release 5.3.0 #848

josemduarte opened this issue Sep 2, 2019 · 6 comments
Labels
organization

Comments

@josemduarte
Copy link
Contributor

@josemduarte josemduarte commented Sep 2, 2019

It's been a while since last release. I'd propose to release 5.3.0 on the 6th of September. It will include some bug fixes, support for BinaryCif and a new mmCIF parser (see #839).

Make sure you commit any contributions that you'd like to see in 5.3.0 before that time.

Question for @JonStargaryen . Should we upgrade the dependency on ciftools-java to latest release 0.5.4?
@JonStargaryen
Copy link
Member

@JonStargaryen JonStargaryen commented Sep 3, 2019 •
edited

@josemduarte Yeah, I recommend bumping the version to 0.5.4. It fixes a bug which can crash CIF writing when concurrency is involved. Moving to 0.5.4 doesn't require any changes in the BioJava code.
@josemduarte
Copy link
Contributor Author

@josemduarte josemduarte commented Sep 3, 2019

Thanks @JonStargaryen , we'll do
@heuermh
Copy link
Member

@heuermh heuermh commented Sep 3, 2019

I don't see a milestone for 5.3.0, I would like to include #852 #851 in this release. I'll also take a look at #843 to see if there is a quick fix.
@josemduarte
Copy link
Contributor Author

@josemduarte josemduarte commented Sep 3, 2019

I don't see a milestone for 5.3.0,

Sorry I didn't create the milestone. There were various outdated milestones that I had to clean up and move around. We'll be more diligent for next release.

I would like to include #852 #851 in this release.

Absolutely, I'll merge them when the tests pass. Thanks

I'll also take a look at #843 to see if there is a quick fix.

That'd be be great, thanks! If you need a bit more time, please let me know.
@sbliven sbliven mentioned this issue Sep 6, 2019
Open
@josemduarte
Copy link
Contributor Author

@josemduarte josemduarte commented Sep 6, 2019

@heuermh would it be ok to postpone #843 to next bugfix release? If ok, I'll go ahead and release 5.3.0 today
@heuermh
Copy link
Member

@heuermh heuermh commented Sep 6, 2019

@josemduarte Yes, I don't have a quick fix for it. Please go ahead with the release!
@josemduarte josemduarte closed this Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
organization
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@heuermh @josemduarte @JonStargaryen
You can’t perform that action at this time.