Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpgrade to latest ciftools #885
Conversation
JonStargaryen
commented
Aug 12, 2020
|
|
Thank you! one comment about the test |
| import static org.junit.Assert.assertEquals; | ||
| import static org.junit.Assert.assertNotNull; | ||
|
|
||
| public class CifFileSupplierTest { |
josemduarte
Aug 12, 2020
Contributor
It'd be better to put this test under the integration test module. We'd like to have a clearer separation of unit tests and integration tests going forward: the structure module should have unit tests, and the integrationtest module should have integration tests.
It'd be better to put this test under the integration test module. We'd like to have a clearer separation of unit tests and integration tests going forward: the structure module should have unit tests, and the integrationtest module should have integration tests.
JonStargaryen
Aug 12, 2020
Author
Member
Seems like we had that discussion already. Just saw that the same test exists in the integrationtest module :) (https://github.com/biojava/biojava/blob/master/biojava-integrationtest/src/test/java/org/biojava/nbio/structure/test/io/cif/CifFileSupplierIntegrationTest.java). I deleted the redundant copy in biojava-structure.
Seems like we had that discussion already. Just saw that the same test exists in the integrationtest module :) (https://github.com/biojava/biojava/blob/master/biojava-integrationtest/src/test/java/org/biojava/nbio/structure/test/io/cif/CifFileSupplierIntegrationTest.java). I deleted the redundant copy in biojava-structure.
|
Thanks! |
