Skip to content

/ phpredis

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5.3.2 Release #1842

Open
GrahamCampbell opened this issue Sep 6, 2020 · 4 comments
Open

5.3.2 Release #1842

GrahamCampbell opened this issue Sep 6, 2020 · 4 comments

Comments

@GrahamCampbell
Copy link
Contributor

@GrahamCampbell GrahamCampbell commented Sep 6, 2020

What's the plan for the next release? 5.3.1 no longer works with PHP 8.0. ;)
@GrahamCampbell GrahamCampbell changed the title 5.3.2 5.3.2 Release Sep 6, 2020
@yatsukhnenko
Copy link
Member

@yatsukhnenko yatsukhnenko commented Sep 9, 2020

I think we may release 5.3.2 right after PHP 8 RC1 to be sure that nothing will be broken
@GrahamCampbell
Copy link
Contributor Author

@GrahamCampbell GrahamCampbell commented Sep 9, 2020

Sounds like a plan. :)
@remicollet
Copy link
Collaborator

@remicollet remicollet commented Sep 11, 2020

Using 8.0.0beta3, all session tests are failing :(

Assertion failed: /work/GIT/pecl-and-ext/redis/tests/RedisTest.php:6256 (testSession_savedToRedis)
Assertion failed: /work/GIT/pecl-and-ext/redis/tests/RedisTest.php:6257 (testSession_savedToRedis)
Assertion failed: /work/GIT/pecl-and-ext/redis/tests/RedisTest.php:6267 (testSession_lockKeyCorrect)
Assertion failed: /work/GIT/pecl-and-ext/redis/tests/RedisTest.php:6284 (testSession_lockingDisabledByDefault)
Assertion failed: /work/GIT/pecl-and-ext/redis/tests/RedisTest.php:6310 (testSession_lock_ttlMaxExecutionTime)
Assertion failed: /work/GIT/pecl-and-ext/redis/tests/RedisTest.php:6326 (testSession_lock_ttlLockExpire)
Assertion failed: /work/GIT/pecl-and-ext/redis/tests/RedisTest.php:6338 (testSession_lockHoldCheckBeforeWrite_otherProcessHasLock)
Assertion failed (secondProcess !== Key redis_test not found): /work/GIT/pecl-and-ext/redis/tests/RedisTest.php:6339 (testSession_lockHoldCheckBeforeWrite_otherProcessHasLock)
Assertion failed: /work/GIT/pecl-and-ext/redis/tests/RedisTest.php:6364 (testSession_correctLockRetryCount)
Assertion failed: /work/GIT/pecl-and-ext/redis/tests/RedisTest.php:6365 (testSession_correctLockRetryCount)
Assertion failed: /work/GIT/pecl-and-ext/redis/tests/RedisTest.php:6380 (testSession_defaultLockRetryCount)
Assertion failed: /work/GIT/pecl-and-ext/redis/tests/RedisTest.php:6381 (testSession_defaultLockRetryCount)
Assertion failed: /work/GIT/pecl-and-ext/redis/tests/RedisTest.php:6400 (testSession_noUnlockOfOtherProcess)
Assertion failed: /work/GIT/pecl-and-ext/redis/tests/RedisTest.php:6401 (testSession_noUnlockOfOtherProcess)
Assertion failed: /work/GIT/pecl-and-ext/redis/tests/RedisTest.php:6416 (testSession_lockWaitTime)
Assertion failed (bar !== Key redis_test not found): /work/GIT/pecl-and-ext/redis/tests/RedisTest.php:6470 (testSession_regenerateSessionId_noLock_noDestroy)
Assertion failed (bar !== Key redis_test not found): /work/GIT/pecl-and-ext/redis/tests/RedisTest.php:6481 (testSession_regenerateSessionId_noLock_withDestroy)
Assertion failed (bar !== Key redis_test not found): /work/GIT/pecl-and-ext/redis/tests/RedisTest.php:6492 (testSession_regenerateSessionId_withLock_noDestroy)
Assertion failed (bar !== Key redis_test not found): /work/GIT/pecl-and-ext/redis/tests/RedisTest.php:6503 (testSession_regenerateSessionId_withLock_withDestroy)
Assertion failed (bar !== Key redis_test not found): /work/GIT/pecl-and-ext/redis/tests/RedisTest.php:6518 (testSession_regenerateSessionId_noLock_noDestroy_withProxy)
Assertion failed (bar !== Key redis_test not found): /work/GIT/pecl-and-ext/redis/tests/RedisTest.php:6533 (testSession_regenerateSessionId_noLock_withDestroy_withProxy)
Assertion failed (bar !== Key redis_test not found): /work/GIT/pecl-and-ext/redis/tests/RedisTest.php:6548 (testSession_regenerateSessionId_withLock_noDestroy_withProxy)
Assertion failed (bar !== Key redis_test not found): /work/GIT/pecl-and-ext/redis/tests/RedisTest.php:6563 (testSession_regenerateSessionId_withLock_withDestroy_withProxy)
Assertion failed (600 !== -2): /work/GIT/pecl-and-ext/redis/tests/RedisTest.php:6572 (testSession_ttl_equalsToSessionLifetime)
Assertion failed (600 !== -2): /work/GIT/pecl-and-ext/redis/tests/RedisTest.php:6583 (testSession_ttl_resetOnWrite)
@remicollet
Copy link
Collaborator

@remicollet remicollet commented Sep 11, 2020

Test suite issue fixed by pr #1845

A minor build warning with beta3

/work/GIT/pecl-and-ext/redis/redis_cluster.c:587:9: warning: case value '1' not in enumerated type 'zend_result' {aka 'enum <anonymous>'} [-Wswitch]
  587 |         case HASH_KEY_IS_STRING:
      |         ^~~~
/work/GIT/pecl-and-ext/redis/redis_cluster.c:591:9: warning: case value '2' not in enumerated type 'zend_result' {aka 'enum <anonymous>'} [-Wswitch]
  591 |         case HASH_KEY_IS_LONG:
      |         ^~~~

WHich will be fixed in RC1 by php/php-src@7be70c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@remicollet @yatsukhnenko @GrahamCampbell
You can’t perform that action at this time.