Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Foreign Key ON UPDATE CASCADE #1025

Merged
merged 13 commits into from Aug 9, 2020
Merged

Conversation

@gitmotte
Copy link
Contributor

@gitmotte gitmotte commented Jul 26, 2020

  • implement COMMENT ON VIEW
  • testcase "testCommentOnView"
    #985
@coveralls
Copy link

@coveralls coveralls commented Jul 26, 2020

Coverage Status

Coverage increased (+0.08%) to 84.153% when pulling 7b31d06 on gitmotte:issue_985 into 57a7dcd on JSQLParser:master.

gitmotte added 2 commits Jul 26, 2020
* add more unittest-assertions
#985
@gitmotte
Copy link
Contributor Author

@gitmotte gitmotte commented Jul 26, 2020

@wumpz i fixed this issue, because i' using ON UPDATE too

Copy link
Member

@wumpz wumpz left a comment

Looks good. But at the moment I am only reviewing via mobile. I will recheck it if I am back on business. Did you replace all occurances of this? If I remember right there was one direct in the alter expression and another in an ForeignIndex class.

@gitmotte
Copy link
Contributor Author

@gitmotte gitmotte commented Jul 26, 2020

Did you replace all occurances of this? If I remember right there was one direct in the alter expression and another in an ForeignIndex class.

Yes, i replaced both. Added the same unit-tests for the AlterExpression variant.

@gitmotte
Copy link
Contributor Author

@gitmotte gitmotte commented Jul 30, 2020

ok, it's ready to merge now :)

@wumpz wumpz merged commit 1e88dd5 into JSQLParser:master Aug 9, 2020
1 check passed
1 check passed
coverage/coveralls Coverage increased (+0.08%) to 84.153%
Details
@gitmotte gitmotte deleted the gitmotte:issue_985 branch Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.