Skip to content

/ JSqlParser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Foreign Key ON UPDATE CASCADE #1025

Merged
merged 13 commits into from Aug 9, 2020
Merged

Support Foreign Key ON UPDATE CASCADE #1025

merged 13 commits into from Aug 9, 2020

Conversation

@gitmotte
Copy link
Contributor

@gitmotte gitmotte commented Jul 26, 2020

  • implement COMMENT ON VIEW
  • testcase "testCommentOnView"
    #985
gitmotte added 2 commits Jul 26, 2020
@gitmotte
https://github.com//issues/985
dce945d
@gitmotte
add 2 unit-tests for given statements
Loading status checks…
3c2c5a1 
#985
@coveralls
Copy link

@coveralls coveralls commented Jul 26, 2020 •
edited

Coverage Status

Coverage increased (+0.08%) to 84.153% when pulling 7b31d06 on gitmotte:issue_985 into 57a7dcd on JSQLParser:master.
gitmotte added 2 commits Jul 26, 2020
@gitmotte
fix formating (line width)
Loading status checks…
f66116f 
#985
@gitmotte
* fix nullpointerexceptions
Loading status checks…
c7cc0d4 
* add more unittest-assertions
#985
@gitmotte
Copy link
Contributor Author

@gitmotte gitmotte commented Jul 26, 2020

@wumpz i fixed this issue, because i' using ON UPDATE too
@wumpz
wumpz reviewed Jul 26, 2020
View changes
Copy link
Member

@wumpz wumpz left a comment

Looks good. But at the moment I am only reviewing via mobile. I will recheck it if I am back on business. Did you replace all occurances of this? If I remember right there was one direct in the alter expression and another in an ForeignIndex class.
gitmotte added 3 commits Jul 26, 2020
@gitmotte
change order to match the same order as in ForeignKeyIndex
a4b8b64
@gitmotte
byAction should not throw an exception (is used by deprecated
91b6fc0 
string-setters)
@gitmotte
add unit-tests for ReferentialAction within AlterExpression
b4aad0c
@gitmotte
Copy link
Contributor Author

@gitmotte gitmotte commented Jul 26, 2020

Did you replace all occurances of this? If I remember right there was one direct in the alter expression and another in an ForeignIndex class.

Yes, i replaced both. Added the same unit-tests for the AlterExpression variant.
gitmotte added 5 commits Jul 26, 2020
@gitmotte
fix toString (added bug on refactoring)
086d208
@gitmotte
javadoc
e2ca929
@gitmotte
test set from get on null-values too
Loading status checks…
06c8666
@gitmotte
refactoring: add and use ReferentialAction() to evaluate enum
Loading status checks…
c5f8ff7 
#985
@gitmotte
refactoring: fix parser that order of referential actions does not
Loading status checks…
df7fcf7 
matter

#985
@gitmotte
Copy link
Contributor Author

@gitmotte gitmotte commented Jul 30, 2020

ok, it's ready to merge now :)
@gitmotte
add empty constructor
Loading status checks…
7b31d06
@wumpz wumpz merged commit 1e88dd5 into JSQLParser:master Aug 9, 2020
1 check passed
1 check passed
coverage/coveralls Coverage increased (+0.08%) to 84.153%
Details
@gitmotte gitmotte deleted the gitmotte:issue_985 branch Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wumpz wumpz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@gitmotte @coveralls @wumpz
You can’t perform that action at this time.