Skip to content

/ shardingsphere

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test cases for sharding strategy #7707

Open
terrymanu opened this issue Oct 8, 2020 · 6 comments
Open

Add test cases for sharding strategy #7707

terrymanu opened this issue Oct 8, 2020 · 6 comments
Labels
good first issue in: test
Milestone
5.0.0-alpha

Comments

@terrymanu
Copy link
Member

@terrymanu terrymanu commented Oct 8, 2020 •
edited

  • Add test case for ShardingStrategyFactory
  • Add test case for StandardShardingStrategy
  • Add test case for ComplexShardingStrategy
  • Add test case for HintShardingStrategy
  • Add test case for NoneShardingStrategy
@terrymanu terrymanu added this to the 5.0.0-alpha milestone Oct 8, 2020
@terrymanu terrymanu changed the title Add test case for ShardingStrategyFactory Add test cases for sharding strategy Oct 8, 2020
@jacksparrow414 jacksparrow414 mentioned this issue Oct 8, 2020
Merged
@jacksparrow414
Copy link
Contributor

@jacksparrow414 jacksparrow414 commented Oct 8, 2020

  • Add test case for ShardingStrategyFactory
@jacksparrow414
Copy link
Contributor

@jacksparrow414 jacksparrow414 commented Oct 9, 2020 •
edited

just finished the first one ,reopen this issue please
@tristaZero
Copy link
Contributor

@tristaZero tristaZero commented Oct 9, 2020 •
edited

@jacksparrow414 Please do not use Fixes #7707 . If this PR does not fix the relevant issue, Ref #7704 or #7704 are recommended. Otherwise, the related issue will be closed with this PR merged
@tristaZero tristaZero reopened this Oct 9, 2020
@jacksparrow414
Copy link
Contributor

@jacksparrow414 jacksparrow414 commented Oct 9, 2020

ok
@jacksparrow414 jacksparrow414 mentioned this issue Oct 9, 2020
Merged
@jacksparrow414
Copy link
Contributor

@jacksparrow414 jacksparrow414 commented Oct 9, 2020

  • Add test case for StandardShardingStrategy
  • Add test case for ComplexShardingStrategy
@jacksparrow414 jacksparrow414 mentioned this issue Oct 10, 2020
Merged
@jacksparrow414
Copy link
Contributor

@jacksparrow414 jacksparrow414 commented Oct 10, 2020

  • Add test case for HintShardingStrategy
  • Add test case for NoneShardingStrategy

All test cases are finished
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue in: test
Projects
None yet
Milestone
5.0.0-alpha
Linked pull requests

Successfully merging a pull request may close this issue.

Add test case for ShardingStrategyFactory
Add test cases for HintShardingStrategy and NoneShardingStrategy
3 participants
@terrymanu @tristaZero @jacksparrow414
You can’t perform that action at this time.