Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove ViewEncapsulation.Native #38882

Closed
wants to merge 2 commits into from
Closed

feat: remove ViewEncapsulation.Native #38882

wants to merge 2 commits into from

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 17, 2020

See the individual commits for more context, but the high-level overview is:

  1. Adds an automated migration that will replace any usages of ViewEncapsulation.Native with ViewEncapsulation.ShadowDom.
  2. Removes the Native value from ViewEncapsulation and replaces any usages in tests and docs with ShadowDom.

@crisbeto crisbeto force-pushed the native-view-encapsulation branch 7 times, most recently from 6d3f47c to e8183bc Compare Sep 17, 2020
@ngbot ngbot bot added this to the needsTriage milestone Sep 17, 2020
@crisbeto crisbeto marked this pull request as ready for review Sep 17, 2020
IgorMinar
IgorMinar approved these changes Sep 17, 2020
View changes
Copy link
Contributor

@IgorMinar IgorMinar left a comment

LGTM with some suggestions. thanks!

packages/core/schematics/migrations/native-view-encapsulation/index.ts Show resolved Hide resolved
packages/core/schematics/migrations/native-view-encapsulation/README.md Show resolved Hide resolved
@crisbeto crisbeto force-pushed the native-view-encapsulation branch from e8183bc to 08ac35f Compare Sep 18, 2020
AndrewKushnir
AndrewKushnir reviewed Sep 18, 2020
View changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

The changes look good, just left 1 minor comment 👍

packages/compiler-cli/test/ngtsc/fake_core/index.ts Show resolved Hide resolved
devversion
devversion approved these changes Sep 22, 2020
View changes
Copy link
Member

@devversion devversion left a comment

LGTM for the migration code.

@crisbeto crisbeto force-pushed the native-view-encapsulation branch from 08ac35f to b9efc1f Compare Sep 25, 2020
@crisbeto
Copy link
Member Author

@crisbeto crisbeto commented Sep 25, 2020

I've addressed the latest set of feedback and added a temporary fallback for code that is still using the Native encapsulation.

@crisbeto crisbeto force-pushed the native-view-encapsulation branch 2 times, most recently from 14c800f to 7eda534 Compare Sep 25, 2020
AndrewKushnir
AndrewKushnir reviewed Sep 28, 2020
View changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Thanks for making updates @crisbeto, I just left a couple comments.

packages/core/src/view/util.ts Show resolved Hide resolved
packages/platform-browser/src/dom/dom_renderer.ts Outdated Show resolved Hide resolved
@crisbeto crisbeto force-pushed the native-view-encapsulation branch from 7eda534 to 6e91023 Compare Sep 29, 2020
@pullapprove pullapprove bot requested review from IgorMinar and jelbourn Oct 6, 2020
@pullapprove pullapprove bot requested a review from AndrewKushnir Oct 6, 2020
AndrewKushnir
AndrewKushnir approved these changes Oct 6, 2020
View changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Reviewed-for: public-api

@pullapprove pullapprove bot requested a review from atscott Oct 6, 2020
atscott
atscott approved these changes Oct 6, 2020
View changes
Copy link
Contributor

@atscott atscott left a comment

reviewed-for: public-api

@pullapprove pullapprove bot requested a review from petebacondarwin Oct 6, 2020
petebacondarwin
petebacondarwin reviewed Oct 6, 2020
View changes
Copy link
Member

@petebacondarwin petebacondarwin left a comment •
edited

Some drive-by comments that you can ignore.

goldens/size-tracking/integration-payloads.json Show resolved Hide resolved
packages/core/src/render3/node_manipulation.ts Outdated Show resolved Hide resolved
packages/platform-browser/testing/src/matchers.ts Show resolved Hide resolved
petebacondarwin
petebacondarwin approved these changes Oct 6, 2020
View changes
Copy link
Member

@petebacondarwin petebacondarwin left a comment

Reviewed-for: public-api

@pullapprove pullapprove bot requested a review from petebacondarwin Oct 6, 2020
petebacondarwin
petebacondarwin approved these changes Oct 6, 2020
View changes
Copy link
Member

@petebacondarwin petebacondarwin left a comment

Reviewed-for: size-tracking

@pullapprove pullapprove bot requested a review from AndrewKushnir Oct 6, 2020
AndrewKushnir
AndrewKushnir approved these changes Oct 6, 2020
View changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Reviewed-for: size-tracking

@josephperrott josephperrott force-pushed the native-view-encapsulation branch from b2fc07d to d0a0037 Compare Oct 6, 2020
crisbeto added 2 commits Oct 8, 2020
@crisbeto
feat(core): add automated migration to replace ViewEncapsulation.Native
adbfde7 
Adds an automated migration that replaces any usages of the deprecated
`ViewEncapsulation.Native` with `ViewEncapsulation.ShadowDom`.
@crisbeto
feat(core): remove ViewEncapsulation.Native
3c47eb2 
Removes `ViewEncapsulation.Native` which has been deprecated for several major versions.

BREAKING CHANGES:
* `ViewEncapsulation.Native` has been removed. Use `ViewEncapsulation.ShadowDom` instead. Existing
usages will be updated automatically by `ng update`.
@crisbeto crisbeto force-pushed the native-view-encapsulation branch from d0a0037 to 3c47eb2 Compare Oct 8, 2020
atscott added a commit that referenced this issue Oct 8, 2020
@crisbeto @atscott
feat(core): remove ViewEncapsulation.Native (#38882)
4a1c12c 
Removes `ViewEncapsulation.Native` which has been deprecated for several major versions.

BREAKING CHANGES:
* `ViewEncapsulation.Native` has been removed. Use `ViewEncapsulation.ShadowDom` instead. Existing
usages will be updated automatically by `ng update`.

PR Close #38882
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Nov 8, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@petebacondarwin petebacondarwin

@IgorMinar IgorMinar

@atscott atscott

@alxhub alxhub

@devversion devversion

@AndrewKushnir AndrewKushnir

Assignees
No one assigned
Labels
action: merge breaking changes cla: yes comp: core cross-cutting: types target: major
Projects
None yet
Milestone
needsTriage
Linked issues

Successfully merging this pull request may close these issues.

None yet
8 participants
@crisbeto @AndrewKushnir @petebacondarwin @IgorMinar @atscott @alxhub @devversion @googlebot