Skip to content
This repository was archived by the owner on Jan 5, 2023. It is now read-only.

Add models for the golang.org/x/sys package#366

Closed
smowton wants to merge 1 commit into
github:mainfrom
smowton:smowton/feature/golang-x-sys-models
Closed

Add models for the golang.org/x/sys package#366
smowton wants to merge 1 commit into
github:mainfrom
smowton:smowton/feature/golang-x-sys-models

Conversation

@smowton
Copy link
Copy Markdown
Contributor

@smowton smowton commented Oct 6, 2020

Many functions are filesystem operation sinks, a few are process executors, and some Windows string transformations now propagate taint.

Many functions are filesystem operation sinks, a few are process executors, and some Windows string transformations now propagate taint.
@smowton smowton requested a review from a team October 6, 2020 16:03
@smowton
Copy link
Copy Markdown
Contributor Author

smowton commented Oct 8, 2020

LGTM analysis showed these additions produce no extra hits on the path-injection or command-injection queries. Guess: the high usage count for this package comes from non-security-relevant parts of it, like golang.org/x/sys/cpu.

@smowton
Copy link
Copy Markdown
Contributor Author

smowton commented Oct 12, 2020

Further analysis of use of the /sys package reveals a small number of calls to a variety of functions within the /unix subpackage and none elsewhere (though that's probably down to selective compilation and our extracting packages in a Unix-like environment). That suggests the large number of packages pulling in the golang.org/x/sys package are doing so for use of constants, not to call anything.

@smowton smowton closed this Oct 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants