Skip to content

/ C-Plus-Plus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new implementation of binary search tree #1208

Open
wants to merge 7 commits into
base: master
from
Open

feat: add new implementation of binary search tree #1208

wants to merge 7 commits into from

Conversation

@Walt280
Copy link

@Walt280 Walt280 commented Oct 7, 2020 •
edited by gitpod-io bot

Description of Change

Add new implementation of binary search tree code using oop, generics, and smart pointers.
Add basic documentation to each of the BST functions.
Add tests for each BST function.

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.
Walt280 added 3 commits Oct 7, 2020
@Walt280
fix: revamp binary_search_tree.cpp to use generics, oop, and modern c…
f89d0a3 
…++ features
@Walt280
Merge remote-tracking branch 'upstream/master' into bst-cleanup
Loading status checks…
3b72ef9
@Walt280
fix: remove make_unique from code
Loading status checks…
607c906
@kvedala
Copy link
Collaborator

@kvedala kvedala commented Oct 7, 2020

If you would like to add a new implementation, review the guidelines. Review the guidelines and the checklist.
@Walt280
fix: fix some clang-tidy errors in binary_search_tree.cpp
Loading status checks…
1f74308
@Walt280 Walt280 marked this pull request as draft Oct 7, 2020
Walt280 added 2 commits Oct 7, 2020
@Walt280
Move new implementation into new file, restore old file.
Loading status checks…
d28d62b
@Walt280
Reset binary_search_tree.cpp to original implementation.
7a7beab
@Walt280 Walt280 changed the title fix: revamp binary_search_tree.cpp feat: add new implementation of binary search tree Oct 7, 2020
@Walt280
Add link to new implementation.
Loading status checks…
607a04a
@Walt280 Walt280 marked this pull request as ready for review Oct 7, 2020
@Walt280
Copy link
Author

@Walt280 Walt280 commented Oct 7, 2020

Okay, I've moved the implementation into a new file.
@Walt280
Copy link
Author

@Walt280 Walt280 commented Oct 8, 2020

This PR is ready for review.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
automated tests are failing awaiting modification enhancement good first issue
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@Walt280 @kvedala
You can’t perform that action at this time.