Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Algorithms for Color Conversions #3048

Open
wants to merge 4 commits into
base: master
from
Open

Added Algorithms for Color Conversions #3048

wants to merge 4 commits into from
+60 −0

Conversation

@hanif-ali
Copy link
Contributor

@hanif-ali hanif-ali commented Oct 8, 2020

  • Add rgb_to_hex color conversion with bound checking
  • Add the reverse hex_to_rgb

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
hanif-ali added 4 commits Oct 6, 2020
@hanif-ali
Hacktoberfest 2020: Added Color Conversions
b67e849 
* rgb_to_hex converter with bound checking
* hex_to_rgb converter with validation

Signed-off-by: Hanif Ali <alihanif016@gmail.com>
@hanif-ali
Merge branch 'master' of github.com:TheAlgorithms/Python into color-c…
Loading status checks…
083dbfb 
…onversions
@hanif-ali
Pre-commit changes
Loading status checks…
7faa6c3 
Signed-off-by: Hanif Ali <alihanif016@gmail.com>
@hanif-ali
Empty Commit to retrigger build
Loading status checks…
2ee48ff
@TravisBuddy
Copy link

@TravisBuddy TravisBuddy commented Oct 8, 2020

Travis tests have failed

Hey @hanif-ali,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 547f8070-095e-11eb-b9d6-41d4da7e5060
@hanif-ali
Copy link
Contributor Author

@hanif-ali hanif-ali commented Oct 8, 2020 •
edited by dhruvmanila

could you please review this?
@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Oct 8, 2020

Please don't @mention any maintainers because you think your PR is more important than others. We will take a look at it one by one. Thank you for your cooperation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@hanif-ali @TravisBuddy @dhruvmanila
You can’t perform that action at this time.