Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Project Euler] Added type hints and refactored the code a bit for Problem 14 #3047

Open
wants to merge 7 commits into
base: master
from
Open

[Project Euler] Added type hints and refactored the code a bit for Problem 14 #3047

wants to merge 7 commits into from
+16 −22

Conversation

@sgalpha01
Copy link
Contributor

@sgalpha01 sgalpha01 commented Oct 8, 2020 •
edited

Continuing #2786

  • Added type hints
  • Added default argument values for validate_solutions script
  • Refactored the code

Describe your change:

  • Fix a bug or typo in an existing algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
sgalpha01 added 2 commits Oct 8, 2020
@sgalpha01
added type hints and refactored the code a bit
Loading status checks…
8dc2413
@sgalpha01
made output statement more explicit
Loading status checks…
5b7c99d
@dhruvmanila
dhruvmanila requested changes Oct 8, 2020
View changes
project_euler/problem_14/sol1.py Outdated Show resolved Hide resolved
project_euler/problem_14/sol2.py Outdated Show resolved Hide resolved
project_euler/problem_14/sol1.py Outdated Show resolved Hide resolved
project_euler/problem_14/sol2.py Outdated Show resolved Hide resolved
project_euler/problem_14/sol2.py Outdated Show resolved Hide resolved
sgalpha01 added 2 commits Oct 8, 2020
@sgalpha01
Merge branch 'master' of https://github.com/TheAlgorithms/Python into…
7a82566 
… patch-project_euler_problem_14
@sgalpha01
used f-strings and updated type hints
Loading status checks…
bb436e2
@sgalpha01
Copy link
Contributor Author

@sgalpha01 sgalpha01 commented Oct 8, 2020 •
edited by dhruvmanila

Hey, thanks for reviewing. I have pushed some changes. Can you please check if it still need any styling changes?
@sgalpha01 sgalpha01 requested a review from dhruvmanila Oct 8, 2020
@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Oct 8, 2020 •
edited

This gives us answer in an incorrect type.
https://travis-ci.com/github/TheAlgorithms/Python/jobs/396914178#L250-L256

And please don't @mention any maintainers, we already have a lot to do and don't get paid for this.
@sgalpha01
Copy link
Contributor Author

@sgalpha01 sgalpha01 commented Oct 8, 2020

Sure!
sgalpha01 added 3 commits Oct 8, 2020
@sgalpha01
Merge branch 'master' of https://github.com/TheAlgorithms/Python into…
2ef0d9b 
… patch-project_euler_problem_14
@sgalpha01
modified solution function to return an integer solution
Loading status checks…
7a60cc7
@sgalpha01
updated docstring
Loading status checks…
7eb2742
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Changes Requested
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@sgalpha01 @dhruvmanila
You can’t perform that action at this time.