Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended soduku solving #3034

Open
wants to merge 8 commits into
base: master
from
Open

Extended soduku solving #3034

wants to merge 8 commits into from

Conversation

@EJG2000
Copy link

@EJG2000 EJG2000 commented Oct 8, 2020

Describe your change:

Extended Sudoku solving using classes in python3
Can solve Sudoku of n size

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • [X ] I have read CONTRIBUTING.md.
  • [ X] This pull request is all my own work -- I have not plagiarized.
  • [ X] I know that pull requests will not be merged if they fail the automated tests.
  • [X ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [X ] All new Python files are placed inside an existing directory.
  • [X ] All filenames are in all lowercase characters with no spaces or dashes.
  • [X ] All functions and variable names follow Python naming conventions.
  • [X ] All function parameters and return values are annotated with Python type hints.
  • [X ] All functions have doctests that pass the automated testing.
  • [X ] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [X ] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@TravisBuddy
Copy link

@TravisBuddy TravisBuddy commented Oct 8, 2020

Travis tests have failed

Hey @EJG2000,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: dd222ae0-0936-11eb-b9d6-41d4da7e5060
@TravisBuddy
Copy link

@TravisBuddy TravisBuddy commented Oct 8, 2020

Travis tests have failed

Hey @EJG2000,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: e1cbc050-0937-11eb-b9d6-41d4da7e5060
EJG2000 added 2 commits Oct 8, 2020
@EJG2000

This comment has been minimized.

Copy link
Author

@EJG2000 EJG2000 commented on 8111f41 Oct 8, 2020

renamed the variable

@EJG2000 EJG2000 force-pushed the EJG2000:master branch from d43e4bd to 2131b4c Oct 8, 2020
@EJG2000 EJG2000 force-pushed the EJG2000:master branch 2 times, most recently from 6dcd9bc to e885f31 Oct 8, 2020
@EJG2000
Copy link
Author

@EJG2000 EJG2000 commented Oct 8, 2020

Pre-commit fails with exit code 1. I could not understand what went wrong.

@EJG2000 EJG2000 force-pushed the EJG2000:master branch from 22f8ef8 to f880b21 Oct 8, 2020
@EJG2000 EJG2000 force-pushed the EJG2000:master branch from f880b21 to fb4c3ee Oct 8, 2020
EJG2000 added 2 commits Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.