Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd event listener lints #110
Merged
Conversation
lib/configs/browser.js
Outdated
| 'github/unescaped-html-literal': 'error', | ||
| 'github/no-useless-passive': 'error', | ||
| 'github/no-non-passive-high-frequency-events': 'error', | ||
| 'github/prefer-observers-over-events': 'error' |
Comment on lines
13
to
16
keithamus
Jul 14, 2020
Author
Member
Do we consider this to be a breaking change? Do we want to release this as semver major?
Do we consider this to be a breaking change? Do we want to release this as semver major?
keithamus
Jul 14, 2020
Author
Member
To answer my own question, precedent exists for this to be semver minor, see #80 which was released as 3.3.0
To answer my own question, precedent exists for this to be semver minor, see #80 which was released as 3.3.0
|
My review might not be worth as much since we worked on this with you but this looks great to me |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
What?
This adds 3 new rules to our
config/browsereslint config:github/no-useless-passivegithub/require-passive-eventsgithub/prefer-observersTo read more about these rules, see the documentation md files in
docs/Why?
These represent our ideal best practices of how to author code for the GitHub frontend, and as such we'd like to enforce these rules with static analysis.