Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hacktoberfest 2020 - Style Improvements for project_euler/problem_26 #2958

Open
wants to merge 10 commits into
base: master
from
Open

Hacktoberfest 2020 - Style Improvements for project_euler/problem_26 #2958

wants to merge 10 commits into from
+36 −4

Conversation

@nstoik
Copy link
Contributor

@nstoik nstoik commented Oct 7, 2020

Describe your change:

Style and testing improvements for Project Euler problem 26

  • add completed problem description
  • add solution() function to pass tests in travis-ci
  • add type hints and default argument to solution() function
  • corrected invocation function of sol1.py as per the Contribution guide

Related to: #2786

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
nstoik added 10 commits Oct 6, 2020
@nstoik
add typehints and docstrings
31e7d92
@nstoik
add typehint and default value
0cdb707
@nstoik
add typehint and default value. Removed unused variable.
Loading status checks…
1ec2a29
@nstoik
do not modifiy the given solution
87f8102
@nstoik
add doctests
Loading status checks…
3641121
@nstoik
update sol1 after running black
Loading status checks…
f8feca3
@nstoik
add typehint, docstring, and doctest
Loading status checks…
f0dc6d9
@nstoik
update sol2 after running black
Loading status checks…
ca26d67
@nstoik
Merge remote-tracking branch 'upstream/master'
a0c31ee
@nstoik
add full problem statement and solution function with typehint and do…
Loading status checks…
e6cac31 
…ctest
@dhruvmanila
dhruvmanila requested changes Oct 7, 2020
View changes
project_euler/problem_26/sol1.py
# Tests
if __name__ == "__main__":
import doctest
def solution(n: int = 1000) -> int:

This comment has been minimized.

Sign in to view
@dhruvmanila

dhruvmanila Oct 7, 2020
Member

Instead of making another function, change the name of the original function and add default arguments to it.
Also, please don't remove the doctest part in if __name__ == "__main__": block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@nstoik @dhruvmanila
You can’t perform that action at this time.