Handle noEmit and noEmitOnError with SemanticDiagnosticsBuilder #40880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandersn
approved these changes
Oct 9, 2020
Looks reasonable although I'm not familiar with this area of the code.
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
sheetalkamat
reviewed
Oct 9, 2020
|
@typescript-bot cherry-pick this to release-4.0 |
|
Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this issue
Oct 14, 2020
Component commits: ca35546 Add test that fails c7b5005 Handle noEmit on semantic builder's emit as well 6a05abd Add test for tsbuildinfo text verification 8bae521 Fix noEmit handling for tsbuildinfo emit with SemanticDiagnosticBuilder 0fd4a08 Add test for noEmitOnError with SemanticDiagnosticsBuilder 4fa1d78 Fix tsbuildinfo emit with SemanticDiagnosticsBuilder on noEmitOnError a3968e7 Update src/compiler/builder.ts Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com> 174b00a Update src/compiler/builder.ts
|
Hey @DanielRosenwasser, I've opened #41107 for you. |
sheetalkamat
added a commit
that referenced
this issue
Oct 15, 2020
Component commits: ca35546 Add test that fails c7b5005 Handle noEmit on semantic builder's emit as well 6a05abd Add test for tsbuildinfo text verification 8bae521 Fix noEmit handling for tsbuildinfo emit with SemanticDiagnosticBuilder 0fd4a08 Add test for noEmitOnError with SemanticDiagnosticsBuilder 4fa1d78 Fix tsbuildinfo emit with SemanticDiagnosticsBuilder on noEmitOnError a3968e7 Update src/compiler/builder.ts Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com> 174b00a Update src/compiler/builder.ts Co-authored-by: Sheetal Nandi <shkamat@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This ensures that diagnostics are checked through cache/or cached in builder instead of getting it from Program when emit is called and its going to fail in these two scenarios. We already do this for
EmitAndSemanticDiagnosticsBuilderNote that actual emit when succeeds on
SemanticDiagnosticsBuilderis going to be redirected to program as intended as the emit is not tracked by the builder and would need to typecheck file before emitting as always but this ensures that cases where it fails to emit are handled.Fixes #40808