Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAddon Actions should have 'new actions' indicator on the addons toolbar tab #11124
Comments
|
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
|
Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook! |
|
Hello @shilman |
|
Hey @Mahyar1982, contributions are always welcome! |
|
@Mahyar1982 are you still interested in making a PR? Otherwise I would like to give it a shot in the next days Were you guys imagining an "unread messages" counter (only displaying new action amount), or a counter always displaying the total amount of actions? |
|
@andre-brdoch No. Please go on. |
I assume it's good to keep consistency with the UI that's already in controls, however controls has a fixed number and actions is dynamic.. thus would be nice to have a way to indicate when a new action is logged so that it can catch the user's attention. Here's the current UI as reference: @domyen have you got any ideas? |
The actions addon is not very useful unless you're on the addons action toolbar tab, there's nothing to notify you when actions are being logged. It would be a great improvement if there was some type of visual indication for when actions are being logged while you are on a different addon tab.
Something like this, but not ugly.
To me the most important feature would be having any type of visual indication, so whatever is simplest will probably be best. I prefer not to use
alertsbut currently some teammates are preferring it for the sake of having active feedback.Another option, though much more involved, would be to mimic chrome devtools behavior for the actions output. In devtools, there is a dedicated console tab. But when you are in any of the other tabs such as Elements, Network etc, hitting the
esckey open the console drawer. It would be interesting if the addons panel had a console drawer of it's own, and addons could log structured output to it, and a keyboard shortcut could toggle it.