Drop RedirectLoop exception #819
Merged
+4
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomchristie
reviewed
Feb 24, 2020
| async def test_redirect_loop(): | ||
| client = AsyncClient(dispatch=MockDispatch()) | ||
| with pytest.raises(RedirectLoop): | ||
| await client.get("https://example.org/redirect_loop") |
There was a problem hiding this comment.
I guess we could keep this test in, and just ensure that TooManyRedirects is raised?
There was a problem hiding this comment.
There is already test for TooManyRedirects with 21 redirects so i thought it's gonna be enough but sure more is better.
tomchristie
approved these changes
Feb 24, 2020
Looks good to me yup!
There's one test case here that we could potentially change to a TooManyRedirects test case. Although I'd probably be happy to accept the PR either way.
Anyone else got feedback on this?
|
Fab, thanks! |
|
Minor API change here, which is fine since we're already commited to the next release being 0.12.0 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Simply drop RedirectLoop exception and instead rely on max number of redirects (and retries on future) like requests, urllib3 and many others do.
More info in previous closed pr #801
The text was updated successfully, but these errors were encountered: