Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax the bounds of some Cupertino text field tests #67020

Merged

Conversation

@jason-simmons
Copy link
Contributor

@jason-simmons jason-simmons commented Sep 30, 2020

SkParagraph may calculate slightly different metrics for text layouts

SkParagraph may calculate slightly different metrics for text layouts
@xster
Copy link
Member

@xster xster commented Oct 1, 2020

LGTM

@fluttergithubbot
Copy link
Contributor

@fluttergithubbot fluttergithubbot commented Oct 1, 2020

This pull request is not suitable for automatic merging in its current state.

  • Please get at least one approved review before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@jason-simmons jason-simmons merged commit c9392da into flutter:master Oct 1, 2020
32 checks passed
32 checks passed
@flutter-dashboard
Linux analyze
Details
@flutter-dashboard
Linux build_tests
Details
@flutter-dashboard
Linux customer_testing
Details
@flutter-dashboard
Linux docs
Details
@flutter-dashboard
Linux firebase_abstract_method_smoke_test
Details
@flutter-dashboard
Linux firebase_android_embedding_v2_smoke_test
Details
@flutter-dashboard
Linux firebase_release_smoke_test
Details
@flutter-dashboard
Linux framework_tests
Details
@flutter-dashboard
Linux fuchsia_precache
Details
@flutter-dashboard
Linux gradle_r8_test
Details
@flutter-dashboard
Linux web_integration_tests
Details
@flutter-dashboard
Linux web_smoke_test
Details
@flutter-dashboard
Linux web_tests
Details
@flutter-dashboard
Mac customer_testing
Details
@flutter-dashboard
Mac framework_tests
Details
@wip
WIP Ready for review
Details
@flutter-dashboard
Windows customer_testing
Details
@flutter-dashboard
Windows framework_tests
Details
@flutter-dashboard
Windows tool_tests
Details
@cirrus-ci
analyze-linux Task Summary
Details
@googlebot
cla/google All necessary CLAs are signed
@cirrus-ci
customer_testing-linux Task Summary
Details
@cirrus-ci
deploy_gallery-linux Task Summary
Details
@cirrus-ci
deploy_gallery-macos Task Summary
Details
@cirrus-ci
docs-linux Task Summary
Details
@flutter-dashboard
flutter-build
Details
@flutter-dashboard
flutter-gold All golden file tests have passed.
Details
@cirrus-ci
framework_tests-libraries-linux Task Summary
Details
@cirrus-ci
framework_tests-misc-linux Task Summary
Details
@cirrus-ci
framework_tests-widgets-linux Task Summary
Details
@cirrus-ci
web_integration_tests Task Summary
Details
@cirrus-ci
web_smoke_test Task Summary
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants