Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested Scaffolds - Suggested Changes #66972

Merged
merged 1 commit into from Sep 30, 2020
Merged

Nested Scaffolds - Suggested Changes #66972

merged 1 commit into from Sep 30, 2020

Conversation

@emem365
Copy link
Contributor

@emem365 emem365 commented Sep 30, 2020

Description

Updating description for Nested Scaffolds. The doc earlier didn't make it clear if we could use multiple scaffolds for multiple routes. Rather it mislead, making users think that there should only be one Scaffold for a whole MaterialApp, which is not the real intent.

Note: I had created a PR earlier (#64645) but because of an unintentional pull the branch got a lot of unintended changes.

Related Issues

Fixes #64136

Tests

Only documentation changed. No tests needed

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change.
@flutter-dashboard
Copy link

@flutter-dashboard flutter-dashboard bot commented Sep 30, 2020

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@emem365
Copy link
Contributor Author

@emem365 emem365 commented Sep 30, 2020

@shihaohong @HansMuller Would be glad if you could please review this PR.

Copy link
Contributor

@shihaohong shihaohong left a comment

LGTM. Thanks for the PR!

@shihaohong shihaohong merged commit 2de1c8d into flutter:master Sep 30, 2020
32 checks passed
32 checks passed
@flutter-dashboard
Linux analyze
Details
@flutter-dashboard
Linux build_tests
Details
@flutter-dashboard
Linux customer_testing
Details
@flutter-dashboard
Linux docs
Details
@flutter-dashboard
Linux firebase_abstract_method_smoke_test
Details
@flutter-dashboard
Linux firebase_android_embedding_v2_smoke_test
Details
@flutter-dashboard
Linux firebase_release_smoke_test
Details
@flutter-dashboard
Linux framework_tests
Details
@flutter-dashboard
Linux fuchsia_precache
Details
@flutter-dashboard
Linux gradle_r8_test
Details
@flutter-dashboard
Linux web_integration_tests
Details
@flutter-dashboard
Linux web_smoke_test
Details
@flutter-dashboard
Linux web_tests
Details
@flutter-dashboard
Mac customer_testing
Details
@flutter-dashboard
Mac framework_tests
Details
@wip
WIP Ready for review
Details
@flutter-dashboard
Windows customer_testing
Details
@flutter-dashboard
Windows framework_tests
Details
@flutter-dashboard
Windows tool_tests
Details
@cirrus-ci
analyze-linux Task Summary
Details
@googlebot
cla/google All necessary CLAs are signed
@cirrus-ci
customer_testing-linux Task Summary
Details
@cirrus-ci
deploy_gallery-linux Task Summary
Details
@cirrus-ci
deploy_gallery-macos Task Summary
Details
@cirrus-ci
docs-linux Task Summary
Details
@flutter-dashboard
flutter-build
Details
@flutter-dashboard
flutter-gold All golden file tests have passed.
Details
@cirrus-ci
framework_tests-libraries-linux Task Summary
Details
@cirrus-ci
framework_tests-misc-linux Task Summary
Details
@cirrus-ci
framework_tests-widgets-linux Task Summary
Details
@cirrus-ci
web_integration_tests Task Summary
Details
@cirrus-ci
web_smoke_test Task Summary
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants