Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup completed todo and unused variable for WidgetTester #66743

Merged
merged 1 commit into from Sep 29, 2020

Conversation

@CareF
Copy link
Contributor

@CareF CareF commented Sep 26, 2020

Description

This is a follow up of #64846 and #61388

#64846 so that a hit test history is no longer needed;

#61388 complete the TODO.

@flutter-dashboard
Copy link

@flutter-dashboard flutter-dashboard bot commented Sep 26, 2020

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Contributor

@liyuqian liyuqian left a comment

LGTM

@fluttergithubbot fluttergithubbot merged commit 3c321ac into flutter:master Sep 29, 2020
33 checks passed
33 checks passed
@flutter-github-sync
Google testing Google testing passed!
Details
@flutter-dashboard
Linux analyze
Details
@flutter-dashboard
Linux build_tests
Details
@flutter-dashboard
Linux customer_testing
Details
@flutter-dashboard
Linux docs
Details
@flutter-dashboard
Linux firebase_abstract_method_smoke_test
Details
@flutter-dashboard
Linux firebase_android_embedding_v2_smoke_test
Details
@flutter-dashboard
Linux firebase_release_smoke_test
Details
@flutter-dashboard
Linux framework_tests
Details
@flutter-dashboard
Linux fuchsia_precache
Details
@flutter-dashboard
Linux gradle_r8_test
Details
@flutter-dashboard
Linux web_integration_tests
Details
@flutter-dashboard
Linux web_smoke_test
Details
@flutter-dashboard
Linux web_tests
Details
@flutter-dashboard
Mac customer_testing
Details
@flutter-dashboard
Mac framework_tests
Details
@wip
WIP Ready for review
Details
@flutter-dashboard
Windows customer_testing
Details
@flutter-dashboard
Windows framework_tests
Details
@flutter-dashboard
Windows tool_tests
Details
@cirrus-ci
analyze-linux Task Summary
Details
@googlebot
cla/google All necessary CLAs are signed
@cirrus-ci
customer_testing-linux Task Summary
Details
@cirrus-ci
deploy_gallery-linux Task Summary
Details
@cirrus-ci
deploy_gallery-macos Task Summary
Details
@cirrus-ci
docs-linux Task Summary
Details
@flutter-dashboard
flutter-build
Details
@flutter-dashboard
flutter-gold All golden file tests have passed.
Details
@cirrus-ci
framework_tests-libraries-linux Task Summary
Details
@cirrus-ci
framework_tests-misc-linux Task Summary
Details
@cirrus-ci
framework_tests-widgets-linux Task Summary
Details
@cirrus-ci
web_integration_tests Task Summary
Details
@cirrus-ci
web_smoke_test Task Summary
Details
@CareF CareF deleted the CareF:remove_compelete_todo branch Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants