Skip to content

/ Javascript

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create AtBash.js #317

Open
wants to merge 2 commits into
base: master
from
Open

Create AtBash.js #317

wants to merge 2 commits into from

Conversation

@aryabharat
Copy link

@aryabharat aryabharat commented Oct 1, 2020 •
edited

Welcome to JavaScript community

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@aryabharat
Create AtBash.js
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4f19129
@lgtm-com
Copy link

@lgtm-com lgtm-com bot commented Oct 1, 2020

This pull request introduces 1 alert when merging 4f19129 into 87e16d5 - view on LGTM.com

new alerts:

  • 1 for Call to eval-like DOM function
@itsvinayak
Update AtBash.js
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
23d1bfd
@itsvinayak
itsvinayak requested changes Oct 1, 2020
View changes
Ciphers/AtBash.js
const alphabet = 'ABCDEFGHIJKLMNOPQRSTUVWXYZ'
const tebahpla = 'ZYXWVUTSRQPONMLKJIHGFEDCBA'
const alphabet1 = 'abcdefghijklmnopqrstuvwxyz'
const tebahpla1 = 'zyxwvutsrqponmlkjihgfedcba'
let decodedString = ''

for (let i = 0; i < message.length; i++) {
const codedLetra = message.charAt(i)
Comment on lines +2 to +9

This comment has been minimized.

Sign in to view
@itsvinayak

itsvinayak Oct 1, 2020
Member

@aryabharat
please add comments, hints, and proper filename.
thanks
@itsvinayak
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsvinayak itsvinayak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@aryabharat @itsvinayak
You can’t perform that action at this time.