C++: Support custom defs in SimpleRangeAnalysis#4322
Merged
Conversation
… into range-analysis-custom-defs
Without these changes, there was no way to tell which variables were overridden by a given instance of `SimpleRangeAnalysisDefinition`. All four overrides are needed because they fit into different mutual recursions of the `SimpleRangeAnalysis` implementation.
This ensures that `getFullyConverted{Lower,Upper}Bounds` are available
where they need to be called.
The def used in this test is not overridden yet.
MathiasVP
reviewed
Sep 22, 2020
geoffw0
approved these changes
Sep 30, 2020
Contributor
geoffw0
left a comment
geoffw0
left a comment
There was a problem hiding this comment.
Two positive reviews and LGTM also.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lcartey, this is based on your initial prototype, but it's a lot more complicated now. I've added extra overrides and parameters to allow specifying which variable in the
RangeSsaDefinitionis being customised.@lcartey, can you validate that this extensibility is sufficient and practical for your use case?