Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFixed calling_conventions tests on MinGW #257
Open
Conversation
On MinGW calling conversion are actually macros that are expanded into a GCC attribute (e.g. `__fastcall` expands into `__attribute__((__fastcall__))`).
|
Ping |
|
Sorry for my silence. Me not being a Windows developer I feel a bit uncomfortable reviewing this. Do you think it would be possible to add a MinGW (cross-)compiler to the mix of compilers we use on Travis-CI or AppVeyor ? That would help prove that things work as intended. |
|
I seen other boost projects use mingw on appveyor, I could have added it here, but I do know nothing about faber (and it seems to not run module tests #254). |
|
OK, fair point. I'll thus try to add MinGW to the mix, then we should be able to see whether this PR fixes one (or more) failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
On MinGW calling conversion are actually macros that are expanded into a GCC attribute (e.g.
__fastcallexpands into__attribute__((__fastcall__))).