A simple try for HKT #40368

ShuiRuTian · 2020-09-03T16:25:49Z

Fixes #1213

Far from complemention, just a try for now.

Backlog for myself

These are not definition, but a simple explaination, for myself.

proper type: a specific type, like number, Array<number>. Array<T> is not, because T is not specific.
type constructor: interface/class accept generic, like Array which accepts 1 and Map which accepts 2. When used in the rest part, often indicate it is a type parameter too.
type parameter: in the declaration, the generic. Like K,V in Map<K,V>
type arguments: generic when use generic class, like number in Array<number>

Two list, one is added ability, one is added error check.

Ability

class/interface accept type constructor as type parameter and map them correctly.
function accept type constructor as type parameter and map them correctly.
extends specific type constructor
type constructor could accept and check constraint

// constraint might be a very complex issue.
interface G1<T extends number>{}
interface G2<T extends string>{}
interface H1<Container<_> extends G1<_>>{}    // Container<string> should report error?
interface H2<Container<_ extends number>>{}
interface H3<Container<_> extends G1<_>|G2<_> >{}
interface H4<Container<_ extends number> extends G1<_ extends boolean>|G2<_ extends boolean> >{}

// Is H4 complex enough? 
// .......No, it just begin. I could not even give a constraint.
// Accorfing to the BFN, this is allowed.
interface H5<K1<K2<K3<_>>>>{}
// Could someone tell me what the hell is this? How could it be used in Scala or Haskell? And how to add constraint fot it?

// from communicity

type guard could change type arguments in type constructor. #1213 (comment)

Error

type parameters and type arguments must match for type constructor
infer type must match, this is an example in scala.

object HelloWorld {
   def main(args: Array[String]) {
      var q: List[Int] = List(1, 2, 3, 4)
      var w: Array[Boolean] = Array(true)
      var t = getData(q,w)
   }
   def getData[T,U,C[_]](a:C[T],b:C[U]) = 1/2
}

Some details.

	typeConstructor	non-typeConstructor
typeParameter	typeConstructorpolymorphism(1)	? (2) //Generic?
non-typeParameter	? (3) //Generic class/function?	proper type (4)

(1)

interface Example<Container<T>>
                  ^----------^

(2)

interface Example<T>
                  ^

(3)

interface Example<T>{}
          ^--------^

const foo : Example<number>
            ^-----^

(4)

number ,Set<number> ...

we could see that Generic has declaration(2) and instance(3).
Similarly, after (1), we need to distinuish declaration and instance, like 1.1 and 1.2

(1.1)
interface Example<Container<T>>
                  ^----------^
(1.2)
interface Example<Container<T>>{
    foo: Container<number>
         ^--------^
}

Generic could already accept constraint, maybe I could add new abstract to use it? As we could see, they are similar in some degrees.


          beta version.


          analytcs something.


          first step!


          continue analytics.


          third step!


          come to mapper.


          Merge remote-tracking branch 'origin/hkt' into hkt


          just update some comment.


          add comment.


          Merge branch 'hkt' of https://github.com/ShuiRuTian/TypeScript into hkt


          work for simple conditon.


          finally, I know the reason.


          works for nested typeconstructor.


          fix quickinfo.

Kingwl · 2020-09-14T03:23:57Z

Cool!

Could you fix the test cases(or lint or merge master) and we could pack this.


          fix and more clear code.


          resolve most baseline.


          fix test case.


          revert useless change for debug.


          just for pass test case.


          for passing.....

...


          fix lint

ShuiRuTian · 2020-09-15T14:44:16Z

Alright, finally......
It is a little harder than estimated, however, it passed........


          extends could work.

Kingwl · 2020-09-16T06:04:49Z

seems not work again....


          fix test.


          Merge remote-tracking branch 'upstream/master' into hkt

ShuiRuTian · 2020-09-16T07:38:30Z

Oh, I see the cute little green check mark and would not push any more until it is packed this time

Kingwl · 2020-09-16T09:14:13Z

@typescript-bot pack this.

typescript-bot · 2020-09-16T09:14:36Z

Heya @Kingwl, I've started to run the tarball bundle task on this PR at a00bd0a. You can monitor the build here.

typescript-bot · 2020-09-16T09:35:03Z

Hey @Kingwl, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/85513/artifacts?artifactName=tgz&fileId=565F0D21981DBF17E9EA13CEC644F3F2B81E0D8A8EA95B514BF63688312A08EB02&fileName=/typescript-4.1.0-insiders.20200916.tgz"
    }
}

and then running npm install.

There is also a playground for this build.

Kingwl · 2020-09-16T09:58:13Z

Soo coooooooooooooooooooooooool!

xiaoxiangmoe · 2020-09-16T10:29:35Z

Excited!

lupuszr · 2020-09-16T11:46:36Z

@ShuiRuTian Really excited about this feature. But if I am not mistaken it seems like it doesn't work for types only interfaces. So we can't create a sum type like:
type Maybe<A> = Just<A> | Nothing;


          test case design.

ShuiRuTian · 2020-09-18T05:35:44Z

@lupuszr
Whoops, I did not think about it.
It would be very helpful if there are some provided examples(the code you expect works). Usually issues come when trying to give a complex example.

lupuszr · 2020-09-18T05:45:12Z

@typescript-bot pack this.

ShuiRuTian · 2020-09-18T05:50:10Z

lol, only TS team member could do that.

lupuszr · 2020-09-18T05:52:21Z

Sorry I hoped I have magic powers like that :D

Anyway what I tested in the last playground was:

In the playground this was my test:

interface Just<A> {value: A, tag: 'Maybe/Just'};
interface Nothing { tag: 'Maybe/Nothing'};
type Maybe<A> = Just<A> | Nothing;

type Functor<F<_>> = {
    map: <A, B>(f: (a: A) => B) => ((fa: F<A>) => F<B>)
}

type Monad<F<_>> = {
    bind: <A, B>(f: (a: A) => F<B>) => ((fa: F<A>) => F<B>)
}

type L = Functor<Maybe>;

and got an error Generic type 'Maybe' requires 1 type argument(s).(2314)

the same happens for:

type Reader<E, A> = (env: E) => A; type R = Functor<Reader>;
as well

Is this handled by your last commit ?

ShuiRuTian · 2020-09-18T06:00:09Z

Not sure, would check when having time. My break time is nearly at an end.


          type alias.


          simple fix.

ShuiRuTian · 2020-09-19T16:00:34Z

@lupuszr Auh, it should work for the sample code now. But I do not fix error and the code is really ugly.....
If you could not wait to see the result, you could fork and build this branch, then change the Typescript what vscode is using.

src/compiler/types.ts


          first step for check error.

orta · 2020-09-22T19:36:45Z

@typescript-bot pack this

typescript-bot · 2020-09-22T19:36:49Z

Heya @orta, I've started to run the tarball bundle task on this PR at 9d1850c. You can monitor the build here.


          fix test and another future fix issue.


          Merge remote-tracking branch 'upstream/master' into hkt

fix


          fix case.


          fix.

ShuiRuTian added 8 commits Aug 31, 2020

beta version.

ad7b7e9

analytcs something.

b97c40a

first step!

bc66c97

continue analytics.

5df3394

third step!

76d4940

come to mapper.

6732416

Merge remote-tracking branch 'origin/hkt' into hkt

Loading status checks…

efacaeb

just update some comment.

4450ac6

typescript-bot added the For Backlog Bug label Sep 3, 2020

ShuiRuTian added 6 commits Sep 4, 2020

add comment.

c67a88a

Merge branch 'hkt' of https://github.com/ShuiRuTian/TypeScript into hkt

63abe6c

work for simple conditon.

Loading status checks…

2bb3a15

finally, I know the reason.

Loading status checks…

57b5acb

works for nested typeconstructor.

Loading status checks…

43041c2

fix quickinfo.

Loading status checks…

1109ab6

ShuiRuTian added 8 commits Sep 14, 2020

fix and more clear code.

Loading status checks…

4356e74

resolve most baseline.

Loading status checks…

e6aab71

fix test case.

Loading status checks…

829e12a

revert useless change for debug.

Loading status checks…

5462278

just for pass test case.

Loading status checks…

0766a75

for passing.....

Loading status checks…

6ef451a

...

Loading status checks…

778e9e3

fix lint

Loading status checks…

9279c21

extends could work.

Loading status checks…

8a247b3

ShuiRuTian added 2 commits Sep 16, 2020

fix test.

Loading status checks…

29e1a56

Merge remote-tracking branch 'upstream/master' into hkt

Loading status checks…

a00bd0a

test case design.

Loading status checks…

4b9eed5

orta added the Experiment label Sep 18, 2020

ShuiRuTian added 2 commits Sep 19, 2020

type alias.

Loading status checks…

63d7b58

simple fix.

Loading status checks…

c71df53

lupuszr reviewed Sep 20, 2020

View changes

src/compiler/types.ts Outdated Show resolved Hide resolved

first step for check error.

Loading status checks…

9d1850c

ShuiRuTian added 5 commits Sep 23, 2020

fix test and another future fix issue.

Loading status checks…

8e9ada1

Merge remote-tracking branch 'upstream/master' into hkt

Loading status checks…

d49f19c

fix

Loading status checks…

ce27b0e

fix case.

Loading status checks…

21bbe6b

fix.

Loading status checks…

8842bad

microsoft / TypeScript

A simple try for HKT #40368

A simple try for HKT #40368

ShuiRuTian commented Sep 3, 2020 •

edited

Kingwl commented Sep 14, 2020

ShuiRuTian commented Sep 15, 2020

Kingwl commented Sep 16, 2020

ShuiRuTian commented Sep 16, 2020

Kingwl commented Sep 16, 2020

typescript-bot commented Sep 16, 2020 •

edited

typescript-bot commented Sep 16, 2020 •

edited

Kingwl commented Sep 16, 2020 •

edited

xiaoxiangmoe commented Sep 16, 2020

lupuszr commented Sep 16, 2020 •

edited

ShuiRuTian commented Sep 18, 2020 •

edited

lupuszr commented Sep 18, 2020

ShuiRuTian commented Sep 18, 2020

lupuszr commented Sep 18, 2020 •

edited

ShuiRuTian commented Sep 18, 2020

ShuiRuTian commented Sep 19, 2020

orta commented Sep 22, 2020

typescript-bot commented Sep 22, 2020 •

edited

microsoft / TypeScript

Join GitHub today

A simple try for HKT #40368

A simple try for HKT #40368

Conversation

ShuiRuTian commented Sep 3, 2020 • edited

Kingwl commented Sep 14, 2020

ShuiRuTian commented Sep 15, 2020

Kingwl commented Sep 16, 2020

ShuiRuTian commented Sep 16, 2020

Kingwl commented Sep 16, 2020

typescript-bot commented Sep 16, 2020 • edited

typescript-bot commented Sep 16, 2020 • edited

Kingwl commented Sep 16, 2020 • edited

xiaoxiangmoe commented Sep 16, 2020

lupuszr commented Sep 16, 2020 • edited

ShuiRuTian commented Sep 18, 2020 • edited

lupuszr commented Sep 18, 2020

ShuiRuTian commented Sep 18, 2020

lupuszr commented Sep 18, 2020 • edited

ShuiRuTian commented Sep 18, 2020

ShuiRuTian commented Sep 19, 2020

orta commented Sep 22, 2020

typescript-bot commented Sep 22, 2020 • edited

ShuiRuTian commented Sep 3, 2020 •

edited

typescript-bot commented Sep 16, 2020 •

edited

typescript-bot commented Sep 16, 2020 •

edited

Kingwl commented Sep 16, 2020 •

edited

lupuszr commented Sep 16, 2020 •

edited

ShuiRuTian commented Sep 18, 2020 •

edited

lupuszr commented Sep 18, 2020 •

edited

typescript-bot commented Sep 22, 2020 •

edited