Skip to content

Handle unsigned types in sign analysis (C# and Java)#4324

Merged
aschackmull merged 1 commit into
github:mainfrom
tamasvajk:feature/unsigned-sign-analysis
Oct 1, 2020
Merged

Handle unsigned types in sign analysis (C# and Java)#4324
aschackmull merged 1 commit into
github:mainfrom
tamasvajk:feature/unsigned-sign-analysis

Conversation

@tamasvajk
Copy link
Copy Markdown
Contributor

@tamasvajk tamasvajk commented Sep 22, 2020

No description provided.

@tamasvajk tamasvajk force-pushed the feature/unsigned-sign-analysis branch from d18f04a to b722e9f Compare September 23, 2020 08:40
@tamasvajk tamasvajk changed the title WIP - unsigned numeric type handling in sign analysis Handle unsigned types in sign analysis (C# and Java) Sep 23, 2020
@tamasvajk tamasvajk force-pushed the feature/unsigned-sign-analysis branch from b722e9f to e204d3d Compare September 25, 2020 07:05
@tamasvajk tamasvajk marked this pull request as ready for review September 28, 2020 09:16
@tamasvajk tamasvajk requested review from a team as code owners September 28, 2020 09:16
@tamasvajk tamasvajk force-pushed the feature/unsigned-sign-analysis branch from e204d3d to 3376ae2 Compare September 28, 2020 09:39
hvitved
hvitved previously approved these changes Sep 28, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aschackmull
aschackmull reviewed Sep 28, 2020
View reviewed changes
Comment thread java/ql/src/semmle/code/java/dataflow/internal/rangeanalysis/SignAnalysisSpecific.qll Outdated
@tamasvajk tamasvajk force-pushed the feature/unsigned-sign-analysis branch from 3376ae2 to 2bbaa4e Compare September 28, 2020 12:47
@tamasvajk
Copy link
Copy Markdown
Contributor Author

tamasvajk commented Sep 28, 2020

Java differences job: https://jenkins.internal.semmle.com/job/Changes/job/Java-Differences/936/

@tamasvajk
Copy link
Copy Markdown
Contributor Author

tamasvajk commented Sep 29, 2020

Java differences job: https://jenkins.internal.semmle.com/job/Changes/job/Java-Differences/936/

The java differences job shows some changes, but they seem independent of this change.

@aschackmull
Copy link
Copy Markdown
Contributor

aschackmull commented Sep 29, 2020

The java differences job shows some changes, but they seem independent of this change.

No? They are indeed very dependent on this change - and the changes look good. Indeed these are FPs that are now fixed due to additional sign information on the char type.

@tamasvajk
Copy link
Copy Markdown
Contributor Author

tamasvajk commented Sep 29, 2020

The java differences job shows some changes, but they seem independent of this change.

No? They are indeed very dependent on this change - and the changes look good. Indeed these are FPs that are now fixed due to additional sign information on the char type.

Ahh, you're right. tainted-arithmetic and uncontrolled-arithmetic are actually checks that are highly dependent on this change. And similar-file is just adding noise in the results.

@tamasvajk
Copy link
Copy Markdown
Contributor Author

tamasvajk commented Sep 30, 2020

@aschackmull Does this PR work for you too? Can I merge it?

@aschackmull
Copy link
Copy Markdown
Contributor

aschackmull commented Oct 1, 2020

Yep, looks good!

@aschackmull aschackmull merged commit c027f3b into github:main Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aschackmull aschackmull aschackmull left review comments

@hvitved hvitved hvitved approved these changes

Assignees

No one assigned

Labels

C# Java

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tamasvajk @aschackmull @hvitved