Skip to content
This repository has been archived by the owner. It is now read-only.

Test failures running with python3 < 3.6 #100

Open
ryanashcraft opened this issue May 20, 2018 · 0 comments
Open

Test failures running with python3 < 3.6 #100

ryanashcraft opened this issue May 20, 2018 · 0 comments

Comments

@ryanashcraft
Copy link
Collaborator

@ryanashcraft ryanashcraft commented May 20, 2018

Currently the test suite covers several python3 language features that did not exist pre-3.6. So running yarn test on a system with python 3.4, for example, you get several tests failing from parse errors. Perhaps we should add an explicit version check before parsing and log a warning or throw an error? plugin-swift does this: https://github.com/prettier/plugin-swift/blob/master/src/parser/wrapper.js.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.