cli / cli

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1755] SSH key management (gh ssh-key list) #1862

Open

edualb wants to merge 9 commits into cli:trunk from edualb:trunk

+484 −16

edualb commented Sep 20, 2020

Command gh ssh-key list implemented.

This feature request can be accessed by #1755 tag.

✅ Command gh ssh-key list - That shows all of the currently SSH-KEY and names.
✅ Test coverage 98%+

Eduardo Albuquerque and others added 7 commits


          add ssh-key command

43e482e


          add read:public_key scope

95ff456


          add list command

ff9b831


          add list command

49cd75b


          Merge branch 'trunk' of github.com:edualb/cli into trunk

f8ab586


          add test for NewCmdList

3c1f0a9


          add error treatments

3bcb259

Author

edualb commented on `3c1f0a9` Sep 20, 2020 •

edited

Do you suggest anything that I can identify the test? I didn't like the id either, but it was the way that I found it.

[Edit]
I noticed that the project uses testify lib, I will implement with this approach.

Author

edualb replied Sep 20, 2020

The id was removed in ffbef3a and 9291212(removed comments only).

If the comment is about the entire TestCmdList, I did it based on status_test.go.

clbreezy84 approved these changes

pkg/cmd/ssh-key/ssh-key.go

  
        package key

        import (

        	cmdList "github.com/cli/cli/pkg/cmd/ssh-key/list"

clbreezy84 Sep 20, 2020

E

edualb added 2 commits


          remove id in list_test

ffbef3a


          remove comments in list_test

TaherAltay mentioned this pull request

Closed

mislav reviewed

Member

mislav left a comment

Hi, thank you for the thorough implementation! The code looks solid at cursory glance.

However, I won't be fully reviewing this PR nor approving it at the moment because, per our CONTRIBUTING policy, we currently don't accept PRs for features that our team hasn't discussed and explicitly approved. Right now, we haven't reached a decision about ssh-key management being included in gh.

In the meantime, you may use your fork or gh api to manage ssh-keys. 🙇

Author

edualb commented Sep 21, 2020

@mislav Alright, no problem. I have learned a lot implementing this feature, thank you for your recognition 😄

So, this PR will be closed? Or, can we wait for the team decision?

Member

mislav commented Sep 21, 2020

We haven't done feature prioritization yet for a post-1.0 release, so let's keep this open until we do, if you don't mind (a couple of weeks tops).

vilmibm added the community label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.