added more :erlang.binary functions

bugfixes related to Symbol ===, added tests
remove rogue comment
elixirscript · bryanjos · Sep 7, 2017 · bryanjos · Sep 7, 2017 · vans163
diff --git a/src/javascript/tests/core/functions.spec.js b/src/javascript/tests/core/functions.spec.js
+  result = Functions.map_to_object(map, []);
+
+  t.deepEqual(result, { s_key: 'value', s_anotherKey: 'value2' });
+});*/
diff --git a/src/javascript/tests/core/functions.spec.js b/src/javascript/tests/core/functions.spec.js
@@ -23,12 +23,28 @@ test('split_at', (t) => {
  t.deepEqual(Functions.split_at('😀abélkm', 4).values, ['😀abé', 'lkm']);
 });

+//TODO: Fix these tests
+/*test('map_to_object/1', (t) => {
diff --git a/src/javascript/tests/core/functions.spec.js b/src/javascript/tests/core/functions.spec.js
@@ -23,12 +23,28 @@ test('split_at', (t) => {
  t.deepEqual(Functions.split_at('😀abélkm', 4).values, ['😀abé', 'lkm']);
 });

+//TODO: Fix these tests
diff --git a/src/javascript/tests/core/erlang_compat/binary_spec.js b/src/javascript/tests/core/erlang_compat/binary_spec.js
+test('split/2', (t) => {
+  let result = Core.binary.split('abcd', 'b');
+  t.deepEqual(result, ['a', 'cd']);
+});
diff --git a/src/javascript/tests/core/erlang_compat/binary_spec.js b/src/javascript/tests/core/erlang_compat/binary_spec.js
+});
+
+test('split/2', (t) => {
+  let result = Core.binary.split('abcd', 'b');
diff --git a/src/javascript/lib/core/functions.js b/src/javascript/lib/core/functions.js
      key = key.toString();
    } else if (
-      (type_keys === Symbol('string') || symbols !== Symbol('undefined')) &&
-      typeof key === 'symbol'
+      (opt_keys === Symbol.for('string') || opt_symbols !== Symbol.for('undefined')) 
diff --git a/src/javascript/lib/core/erlang_compat/binary.js b/src/javascript/lib/core/erlang_compat/binary.js
+  part,
+  replace,
+  split,
+};
diff --git a/src/javascript/lib/core/erlang_compat/binary.js b/src/javascript/lib/core/erlang_compat/binary.js
+//TODO: Support more options, global is implied
+//TODO: pattern cannot be list of strings
+function split(subject, pattern, options=[]) {
+    return subject.split(pattern)
diff --git a/src/javascript/lib/core/erlang_compat/binary.js b/src/javascript/lib/core/erlang_compat/binary.js
+//TODO: Support more options, global is implied
+//TODO: pattern cannot be list of strings
+function split(subject, pattern, options=[]) {
+    return subject.split(pattern)
diff --git a/src/javascript/lib/core/erlang_compat/binary.js b/src/javascript/lib/core/erlang_compat/binary.js
+
+//TODO: Support more options, global is implied
+//TODO: pattern cannot be list of strings
+function split(subject, pattern, options=[]) {
diff --git a/src/javascript/tests/core/erlang_compat/proplists_spec.js b/src/javascript/tests/core/erlang_compat/proplists_spec.js
+});
+
+test('is_defined/2', (t) => {
+  let result = Core.binary.at('abc', 0);
diff --git a/src/javascript/tests/core/erlang_compat/proplists_spec.js b/src/javascript/tests/core/erlang_compat/proplists_spec.js
+  t.deepEqual(result, '123');
+
+  result = Core.proplists.get_value('abcd', [new Core.Tuple('abc', '123')], "xyz");
+  t.deepEqual(result, "xyz");
diff --git a/src/javascript/tests/core/erlang_compat/proplists_spec.js b/src/javascript/tests/core/erlang_compat/proplists_spec.js
+  let result = Core.proplists.get_value('abc', [new Core.Tuple('abc', '123')], "xyz");
+  t.deepEqual(result, '123');
+
+  result = Core.proplists.get_value('abcd', [new Core.Tuple('abc', '123')], "xyz");
diff --git a/src/javascript/tests/core/erlang_compat/proplists_spec.js b/src/javascript/tests/core/erlang_compat/proplists_spec.js
+});
+
+test('get_value/3', (t) => {
+  let result = Core.proplists.get_value('abc', [new Core.Tuple('abc', '123')], "xyz");
diff --git a/src/javascript/tests/core/erlang_compat/proplists_spec.js b/src/javascript/tests/core/erlang_compat/proplists_spec.js
@@ -0,0 +1,26 @@
+import test from 'ava';
diff --git a/src/javascript/lib/core/erlang_compat/proplists.js b/src/javascript/lib/core/erlang_compat/proplists.js
@@ -1,10 +1,13 @@
+import ErlangTypes from 'erlang-types';
diff --git a/src/javascript/lib/core/erlang_compat/binary.js b/src/javascript/lib/core/erlang_compat/binary.js
+}
+
+//TODO: Support more options, global is implied
+//TODO: pattern cannot be list of strings
diff --git a/src/javascript/lib/core/erlang_compat/binary.js b/src/javascript/lib/core/erlang_compat/binary.js
+  return subject.replace(regex, replacement);
+}
+
+//TODO: Support more options, global is implied
diff --git a/src/javascript/lib/core/erlang_compat/binary.js b/src/javascript/lib/core/erlang_compat/binary.js
+function replace(subject, pattern, replacement, options=[]) {
+  const opt_global = proplists.get_value(Symbol.for('global'), options);
+
+  var regex;
diff --git a/src/javascript/lib/core/erlang_compat/binary.js b/src/javascript/lib/core/erlang_compat/binary.js
+
+//TODO: Support more options
+//TODO: pattern cannot be list of strings
+function replace(subject, pattern, replacement, options=[]) {
diff --git a/src/javascript/lib/core/erlang_compat/binary.js b/src/javascript/lib/core/erlang_compat/binary.js
+    var pos;
+    [pos, len] = posOrTuple.values;
+    return subject.substr(pos, len);
+  } else {
diff --git a/src/javascript/lib/core/erlang_compat/binary.js b/src/javascript/lib/core/erlang_compat/binary.js
+function part(subject, posOrTuple, len = null) {
+  if (len === null) {
+    var pos;
+    [pos, len] = posOrTuple.values;
diff --git a/src/javascript/lib/core/erlang_compat/binary.js b/src/javascript/lib/core/erlang_compat/binary.js
 function list_to_bin(bytelist) {
  return erlang.list_to_binary(bytelist);
 }

+function part(subject, posOrTuple, len = null) {
+  if (len === null) {
+    var pos;
diff --git a/src/javascript/lib/core/erlang_compat/binary.js b/src/javascript/lib/core/erlang_compat/binary.js
 function list_to_bin(bytelist) {
  return erlang.list_to_binary(bytelist);
 }

+function part(subject, posOrTuple, len = null) {
+  if (len === null) {
+    var pos;
diff --git a/src/javascript/tests/core/functions.spec.js b/src/javascript/tests/core/functions.spec.js
+    new Map([[Symbol.for('nest1'), 'valuenest1']]),
+    new Map([[Symbol.for('nest2'), 'valuenest2']])
+  ]]]));
+});
diff --git a/src/javascript/tests/core/functions.spec.js b/src/javascript/tests/core/functions.spec.js
+    new Core.Tuple(Symbol.for('recurse_array'), true)]);
+  t.deepEqual(result, new Map([[Symbol.for('key'), [
+    new Map([[Symbol.for('nest1'), 'valuenest1']]),
+    new Map([[Symbol.for('nest2'), 'valuenest2']])
diff --git a/src/javascript/tests/core/functions.spec.js b/src/javascript/tests/core/functions.spec.js
+  obj = {};
+  obj[Symbol.for('key')] = [{nest1: 'valuenest1'},{nest2: 'valuenest2'}];
+  result = Functions.object_to_map(obj, [
+    new Core.Tuple(Symbol.for('keys'), Symbol.for('atom')), 
diff --git a/src/javascript/tests/core/functions.spec.js b/src/javascript/tests/core/functions.spec.js
+  t.deepEqual(result, new Map([[Symbol.for('key'), 'value']]));
+
+  obj = {};
+  obj[Symbol.for('key')] = [{nest1: 'valuenest1'},{nest2: 'valuenest2'}];
diff --git a/src/javascript/tests/core/functions.spec.js b/src/javascript/tests/core/functions.spec.js
+  t.deepEqual(result, new Map([[Symbol.for('key'), 'value']]));
+
+  obj = {};
+  obj[Symbol.for('key')] = [{nest1: 'valuenest1'},{nest2: 'valuenest2'}];
diff --git a/src/javascript/lib/core/functions.js b/src/javascript/lib/core/functions.js
+    return map;
+
+  } else if (object instanceof Array && opt_recurse_array) {
+    return object.map(function(ele) {
diff --git a/src/javascript/lib/core/functions.js b/src/javascript/lib/core/functions.js
+    return map;
+
+  } else if (object instanceof Array && opt_recurse_array) {
+    return object.map(function(ele) {
diff --git a/src/javascript/lib/core/functions.js b/src/javascript/lib/core/functions.js
+    });
+    return map;
+
+  } else if (object instanceof Array && opt_recurse_array) {
diff --git a/src/javascript/lib/core/functions.js b/src/javascript/lib/core/functions.js
+
+  if (object.constructor === Object) {
+    let map = new Map();
+    Reflect.ownKeys(object).forEach(key => {
diff --git a/src/javascript/lib/core/functions.js b/src/javascript/lib/core/functions.js
+  const opt_recurse_array = proplists.get_value(Symbol.for('recurse_array'), options) === true;
+
+  if (object.constructor === Object) {
+    let map = new Map();
diff --git a/lib/elixir_script/lib/js.ex b/lib/elixir_script/lib/js.ex
+  Takes the given object and returns a map
+  Options include [{:keys, :atom}, {:recurse_array, true}]
+
+
diff --git a/src/javascript/lib/core/erlang_compat/binary.js b/src/javascript/lib/core/erlang_compat/binary.js
+
+//TODO: Support more options, global is implied
+//TODO: pattern cannot be list of strings
+function split(subject, pattern, options = []) {
diff --git a/src/javascript/lib/core/erlang_compat/binary.js b/src/javascript/lib/core/erlang_compat/binary.js
+function replace(subject, pattern, replacement, options = []) {
+  const opt_global = proplists.get_value(Symbol.for('global'), options);
+
+  var regex;
diff --git a/src/javascript/lib/core/erlang_compat/binary.js b/src/javascript/lib/core/erlang_compat/binary.js
+
+function last(subject) {
+  if (subject.length == 0) {
+    throw new Error(`Binary is of length 0`);
diff --git a/src/javascript/lib/core/erlang_compat/binary.js b/src/javascript/lib/core/erlang_compat/binary.js
+}
+
+function last(subject) {
+  if (subject.length == 0) {
diff --git a/src/javascript/lib/core/erlang_compat/binary.js b/src/javascript/lib/core/erlang_compat/binary.js

 function copy(subject, n = 1) {
  return subject.repeat(n);
 }

+function first(subject) {
+  if (subject.length == 0) {
+    throw new Error(`Binary is of length 0`);
diff --git a/lib/elixir_script/passes/translate/forms/js.ex b/lib/elixir_script/passes/translate/forms/js.ex
@@ -91,27 +91,56 @@ defmodule ElixirScript.Translate.Forms.JS do
    {ast, state}
  end

-  def compile({{:., _, [ElixirScript.JS, :map_to_object]}, _, [object]}, state) do
+  def compile({{:., _, [ElixirScript.JS, :map_to_object]}, _, [map]}, state) do
diff --git a/lib/elixir_script/passes/translate/forms/js.ex b/lib/elixir_script/passes/translate/forms/js.ex
      ]
    )

    {ast, state}
  end

-  def compile({{:., _, [ElixirScript.JS, :map_to_object]}, _, [object, options]}, state) do
+  def compile({{:., _, [ElixirScript.JS, :map_to_object]}, _, [map, options]}, state) do
diff --git a/lib/elixir_script/passes/translate/forms/js.ex b/lib/elixir_script/passes/translate/forms/js.ex
+    {ast, state}
+  end
+
+  def compile({{:., _, [ElixirScript.JS, :object_to_map]}, _, [object]}, state) do
diff --git a/lib/elixir_script/passes/translate/forms/js.ex b/lib/elixir_script/passes/translate/forms/js.ex
+    {ast, state}
+  end
+
+  def compile({{:., _, [ElixirScript.JS, :object_to_map]}, _, [object, options]}, state) do
		Takes the given object and returns a map
		Options include [{:keys, :atom}, {:recurse_array, true}]